Skip to content

[Merged by Bors] - doc(Algebra/Module/Projective): remove TODOs#38967

Closed
abeldonate wants to merge 1 commit into
leanprover-community:masterfrom
abeldonate:projective-todo
Closed

[Merged by Bors] - doc(Algebra/Module/Projective): remove TODOs#38967
abeldonate wants to merge 1 commit into
leanprover-community:masterfrom
abeldonate:projective-todo

Conversation

@abeldonate

Copy link
Copy Markdown
Contributor

Remove the TODO list, since the have already been implemented on an instance.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

PR summary 20c3a51ac9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@abeldonate abeldonate changed the title doc (remove TODOs) doc(Algebra/Module/Projective): remove TODOs May 5, 2026

@robin-carlier robin-carlier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 11, 2026
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 12, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 12, 2026
Remove the TODO list, since the have already been implemented on an instance.

Co-authored-by: abeldonate <abeldm3108@gmail.com>
@mathlib-bors

mathlib-bors Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title doc(Algebra/Module/Projective): remove TODOs [Merged by Bors] - doc(Algebra/Module/Projective): remove TODOs May 12, 2026
@mathlib-bors mathlib-bors Bot closed this May 12, 2026
@vlad902

vlad902 commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Which instance? loogle doesn't find anything for DirectSum, Module.Projective

@vlad902

vlad902 commented May 23, 2026

Copy link
Copy Markdown
Collaborator

i.e. the following fails for me on main

import Mathlib

variable (R : Type) [CommRing R] {ι : Type v} (M : ι → Type) [(i : ι) → AddCommMonoid (M i)] [(i : ι) → Module R (M i)] [∀ (i : ι), Module.Projective R (M i)]

#synth Module.Projective R (DirectSum ι (fun (i : ι) => M i))

@vlad902

vlad902 commented May 24, 2026

Copy link
Copy Markdown
Collaborator

#39764

@abeldonate

Copy link
Copy Markdown
Contributor Author

I the file Algebra/Module/Projective, i see the following instances:

instance [Projective R P] [Projective R Q] : Projective R (P × Q)
instance [h : ∀ i : ι, Projective R (A i)] : Projective R (Π₀ i, A i)

around line 138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants