[Merged by Bors] - doc(Algebra/Module/Projective): remove TODOs#38967
[Merged by Bors] - doc(Algebra/Module/Projective): remove TODOs#38967abeldonate wants to merge 1 commit into
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 20c3a51ac9Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
robin-carlier
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by robin-carlier. |
|
Thanks! bors merge |
Remove the TODO list, since the have already been implemented on an instance. Co-authored-by: abeldonate <abeldm3108@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
|
Which instance? loogle doesn't find anything for |
|
i.e. the following fails for me on main import Mathlib
variable (R : Type) [CommRing R] {ι : Type v} (M : ι → Type) [(i : ι) → AddCommMonoid (M i)] [(i : ι) → Module R (M i)] [∀ (i : ι), Module.Projective R (M i)]
#synth Module.Projective R (DirectSum ι (fun (i : ι) => M i)) |
|
I the file Algebra/Module/Projective, i see the following instances:
around line 138 |
Remove the TODO list, since the have already been implemented on an instance.