[Merged by Bors] - feat: generalize OpenPartialHomeomorph.Defs file to PartialHomeomorph#39084
Closed
scholzhannah wants to merge 27 commits into
Closed
[Merged by Bors] - feat: generalize OpenPartialHomeomorph.Defs file to PartialHomeomorph#39084scholzhannah wants to merge 27 commits into
OpenPartialHomeomorph.Defs file to PartialHomeomorph#39084scholzhannah wants to merge 27 commits into
Conversation
PR summary 8748a35de3Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (weak) |
|---|---|---|
| 4948 | 1 | exposed public sections |
Current commit 8748a35de3
Reference commit 7d46b4c5ac
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
github-actions
Bot
added
the
t-topology
j-loreaux
reviewed
May 16, 2026
j-loreaux
added
the
awaiting-author
scholzhannah
removed
the
awaiting-author
Collaborator
Author
|
I have now put all the renames in the #39565. Sorry for the giant mess in the commit history, I clearly didn't do the rebase well. Is there any way to clean this mess up now? I hope it magically goes away when the other PR is merged. |
scholzhannah
added
the
blocked-by-other-PR
Contributor
|
I've made a similar git mess myself before. I think you can fix this by doing |
scholzhannah
force-pushed
the
PartialHomeomorph1
branch
from
May 19, 2026 11:14
ccff032 to
0b8c590
Compare
Collaborator
Author
Thanks a lot! I think I might have fixed it now haha. |
… into PartialHomeomorph1
… into PartialHomeomorph1
grunweg
reviewed
Jun 5, 2026
grunweg
left a comment
grunweg
left a comment
Contributor
There was a problem hiding this comment.
First batch of comments!
grunweg
reviewed
Jun 5, 2026
grunweg
reviewed
Jun 5, 2026
grunweg
left a comment
grunweg
left a comment
Contributor
There was a problem hiding this comment.
Remaining comments. Thanks a lot for doing this, I have only minor comments!
grunweg
added
the
awaiting-author
1 task
scholzhannah
removed
the
awaiting-author
j-loreaux
reviewed
Jun 16, 2026
Contributor
|
✌️ scholzhannah can now approve this pull request until 2026-06-30 18:47 UTC (in 2 weeks). To approve and merge, reply with
|
mathlib-triage
Bot
added
the
delegated
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
…0717) The new name avoids a double prime and also matches the naming convention. As suggested [here](#39084 (comment)).
Collaborator
Author
|
bors r+ |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
…rph` (#39084) Add `PartialHomeomorph`, which generalises `OpenPartialHomoemorph` by dropping the condition that the source and target be open. In other words, an `OpenPartialHomeomorph` is a `PartialHomeomorph` that additionally has open source and target. This generalisation should find uses for manifolds (extended charts are `PartialHomeomorph`s, but their target is not open for manifolds with boundary). For CW complexes, we will want a `ClosedPartialHomeomorph`: this allows re-using results as much as possible. This PR adds the basic definitions; future PRs will add additional material: #39071 indicates what the eventual result may be. Zulip discussion: [#mathlib4 > Generalizing `PartialHomeomorph`?](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Generalizing.20.60PartialHomeomorph.60.3F/with/536896273)
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
Bot
changed the title
OpenPartialHomeomorph.Defs file to PartialHomeomorphOpenPartialHomeomorph.Defs file to PartialHomeomorph
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Jun 18, 2026
…anprover-community#40717) The new name avoids a double prime and also matches the naming convention. As suggested [here](leanprover-community#39084 (comment)).
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Jun 18, 2026
…rph` (leanprover-community#39084) Add `PartialHomeomorph`, which generalises `OpenPartialHomoemorph` by dropping the condition that the source and target be open. In other words, an `OpenPartialHomeomorph` is a `PartialHomeomorph` that additionally has open source and target. This generalisation should find uses for manifolds (extended charts are `PartialHomeomorph`s, but their target is not open for manifolds with boundary). For CW complexes, we will want a `ClosedPartialHomeomorph`: this allows re-using results as much as possible. This PR adds the basic definitions; future PRs will add additional material: leanprover-community#39071 indicates what the eventual result may be. Zulip discussion: [#mathlib4 > Generalizing &leanprover-community#96;PartialHomeomorph&leanprover-community#96;?](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Generalizing.20.60PartialHomeomorph.60.3F/with/536896273)
ReemMelamed
pushed a commit
to ReemMelamed/mathlib4
that referenced
this pull request
Jun 20, 2026
…anprover-community#40717) The new name avoids a double prime and also matches the naming convention. As suggested [here](leanprover-community#39084 (comment)).
ReemMelamed
pushed a commit
to ReemMelamed/mathlib4
that referenced
this pull request
Jun 20, 2026
…rph` (leanprover-community#39084) Add `PartialHomeomorph`, which generalises `OpenPartialHomoemorph` by dropping the condition that the source and target be open. In other words, an `OpenPartialHomeomorph` is a `PartialHomeomorph` that additionally has open source and target. This generalisation should find uses for manifolds (extended charts are `PartialHomeomorph`s, but their target is not open for manifolds with boundary). For CW complexes, we will want a `ClosedPartialHomeomorph`: this allows re-using results as much as possible. This PR adds the basic definitions; future PRs will add additional material: leanprover-community#39071 indicates what the eventual result may be. Zulip discussion: [#mathlib4 > Generalizing &leanprover-community#96;PartialHomeomorph&leanprover-community#96;?](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Generalizing.20.60PartialHomeomorph.60.3F/with/536896273)
bryangingechen
pushed a commit
to jcommelin/mathlib4
that referenced
this pull request
Jun 22, 2026
…anprover-community#40717) The new name avoids a double prime and also matches the naming convention. As suggested [here](leanprover-community#39084 (comment)).
bryangingechen
pushed a commit
to jcommelin/mathlib4
that referenced
this pull request
Jun 22, 2026
…rph` (leanprover-community#39084) Add `PartialHomeomorph`, which generalises `OpenPartialHomoemorph` by dropping the condition that the source and target be open. In other words, an `OpenPartialHomeomorph` is a `PartialHomeomorph` that additionally has open source and target. This generalisation should find uses for manifolds (extended charts are `PartialHomeomorph`s, but their target is not open for manifolds with boundary). For CW complexes, we will want a `ClosedPartialHomeomorph`: this allows re-using results as much as possible. This PR adds the basic definitions; future PRs will add additional material: leanprover-community#39071 indicates what the eventual result may be. Zulip discussion: [#mathlib4 > Generalizing &leanprover-community#96;PartialHomeomorph&leanprover-community#96;?](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Generalizing.20.60PartialHomeomorph.60.3F/with/536896273)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
PartialHomeomorph, which generalisesOpenPartialHomoemorphby dropping the condition that the source and target be open. In other words, anOpenPartialHomeomorphis aPartialHomeomorphthat additionally has open source and target.This generalisation should find uses for manifolds (extended charts are
PartialHomeomorphs, but their target is not open for manifolds with boundary). For CW complexes, we will want aClosedPartialHomeomorph: this allows re-using results as much as possible.This PR adds the basic definitions; future PRs will add additional material: #39071 indicates what the eventual result may be.
Zulip discussion: #mathlib4 > Generalizing `PartialHomeomorph`?
old description:
As discussed on Zulip (#mathlib4 > Generalizing `PartialHomeomorph`?), I renamed
PartialHomeomorphtoOpenPartialHomeomorphin #29113.In this PR I now add a new
PartialHomeomorphwhich is aPartialEquivthat is continuous on both source and target. AnOpenPartialHomeomorphis then aPartialHomeomorphthat additionally has open source and target. In subsequent PRs I will generalize the other files. See this draft PR (#39071) for what I think the end result might be.PartialHomeomorphshould find uses at least for manifolds (ModelWithCorners). Afterwards, I want to add aClosedPartialHomeomorphto use for CWComplexes.I don't have a lot of experience doing these kind of modifications of a large piece of code. Additionally, I am not familiar with the main uses of
OpenPartialHomeomorphin Mathlib. So while I did this to the best of my abilities, you should read this carefully because there might be things I did wrong or in non-ideal ways.