[Merged by Bors] - feat: LinearMap.HasFiniteRange and the associated relation#39468
[Merged by Bors] - feat: LinearMap.HasFiniteRange and the associated relation#39468ADedecker wants to merge 17 commits into
Conversation
PR summary cf64666bd1Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
ocfnash
left a comment
There was a problem hiding this comment.
I think we should name the new file Mathlib.LinearAlgebra.LinearMap.FiniteRank rather than Mathlib.LinearAlgebra.FiniteRankLinearMap.
Other than this, and the question about what should be the definition, this all looks perfect.
|
-awaiting-author |
|
Regarding the naming, there's no |
|
This PR/issue depends on:
|
ocfnash
left a comment
There was a problem hiding this comment.
Thanks! Very nice.
As to the location for the new file, I had a typo in this comment but I intended to suggest that the new file could be a sibling of the existing Defs file in which LinearMap is defined. That would make it: Mathlib.Algebra.Module.LinearMap.FiniteRange.
However what you have proposed is also fine so I'll let you decide.
bors d+
| theorem hasFiniteRange_iff_ker {f : V →ₗ[K] V₂} : | ||
| f.HasFiniteRange ↔ f.ker.CoFG := |
There was a problem hiding this comment.
Assuming the simpNF linter is happy I suggest we flip the LHS and RHS and add simp:
| theorem hasFiniteRange_iff_ker {f : V →ₗ[K] V₂} : | |
| f.HasFiniteRange ↔ f.ker.CoFG := | |
| @[simp] theorem ker_coFG_iff {f : V →ₗ[K] V₂} : | |
| f.ker.CoFG ↔ f.HasFiniteRange := |
(if not, this can stay as it is)
There was a problem hiding this comment.
Done, but I kept hasFiniteRange in the name.
|
✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thanks for the review! bors merge |
|
bors r- |
|
Canceled. Address comments or fix if necessary, and then someone with permission can run |
|
bors merge |
We add two predicates on linear maps: `HasFiniteRange` says that the range is finitely generated, and `HasNoetherianRange` says that the range is noetherian. We also add the equivalence relation on linear maps saying that two maps differ by a linear map with noetherian range, and prove that it's compatible with addition and composition. This was originally written by @PatrickMassot at the May 2026 ICERM workshop as part of the project on Fredholm operators. This also adds four supporting lemmas: `map_smul_le_map`, `range_smul_le_range`, `ker_le_ker_smul` and `isNoetherian_map`.
|
Pull request successfully merged into master. Build succeeded: |
…r-community#39468) We add two predicates on linear maps: `HasFiniteRange` says that the range is finitely generated, and `HasNoetherianRange` says that the range is noetherian. We also add the equivalence relation on linear maps saying that two maps differ by a linear map with noetherian range, and prove that it's compatible with addition and composition. This was originally written by @PatrickMassot at the May 2026 ICERM workshop as part of the project on Fredholm operators. This also adds four supporting lemmas: `map_smul_le_map`, `range_smul_le_range`, `ker_le_ker_smul` and `isNoetherian_map`.
…r-community#39468) We add two predicates on linear maps: `HasFiniteRange` says that the range is finitely generated, and `HasNoetherianRange` says that the range is noetherian. We also add the equivalence relation on linear maps saying that two maps differ by a linear map with noetherian range, and prove that it's compatible with addition and composition. This was originally written by @PatrickMassot at the May 2026 ICERM workshop as part of the project on Fredholm operators. This also adds four supporting lemmas: `map_smul_le_map`, `range_smul_le_range`, `ker_le_ker_smul` and `isNoetherian_map`.
We add two predicates on linear maps:
HasFiniteRangesays that the range is finitely generated, andHasNoetherianRangesays that the range is noetherian. We also add the equivalence relation on linear maps saying that two maps differ by a linear map with noetherian range, and prove that it's compatible with addition and composition.This was originally written by @PatrickMassot at the May 2026 ICERM workshop as part of the project on Fredholm operators.
This also adds four supporting lemmas:
map_smul_le_map,range_smul_le_range,ker_le_ker_smulandisNoetherian_map.