[Merged by Bors] - feat(Geometry/Convex): modules are convex spaces#39531
Closed
YaelDillies wants to merge 4 commits into
Closed
[Merged by Bors] - feat(Geometry/Convex): modules are convex spaces#39531YaelDillies wants to merge 4 commits into
YaelDillies wants to merge 4 commits into
Conversation
PR summary f6e2fcbfe6
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Analysis.Convex.MetricSpace | 1490 | 1492 | +2 (+0.13%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Analysis.Convex.MetricSpace |
2 |
Mathlib.Geometry.Convex.ConvexSpace.Module (new file) |
1033 |
Declarations diff
+ ConvexSpace.ofModule
+ IsModuleConvexSpace
+ IsModuleConvexSpace.ofModule
+ convexCombPair_eq_sum
+ convexSpaceSelf
+ fst_convexCombPair
+ iConvexComb_apply
+ iConvexComb_reindex
+ instance : ConvexSpace R (ι →₀ X) := .mk
+ instance [ConvexSpace R N] [IsModuleConvexSpace R N] : IsModuleConvexSpace R (M × N)
+ instance {ι : Type*} : IsModuleConvexSpace R (ι →₀ M)
+ instance {ι : Type*} {M : ι → Type*} [∀ i, AddCommMonoid (M i)] [∀ i, Module R (M i)]
+ isAffineMap_eval
+ isModuleConvexSpace_self
+ onFinsetSupport
+ sConvexComb_apply
+ snd_convexCombPair
++ convexCombPair_apply
- convexCombPair_eq_add
- sConvexComb_eq_sum
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to strong technical debt.
No changes to weak technical debt.
ocfnash
reviewed
May 18, 2026
ocfnash
added
the
awaiting-author
YaelDillies
force-pushed
the
convex_space_module
branch
from
May 19, 2026 12:22
6cabf9d to
a7bbdb4
Compare
YaelDillies
removed
the
awaiting-author
YaelDillies
force-pushed
the
convex_space_module
branch
from
May 20, 2026 10:39
c985d0e to
e718c92
Compare
Contributor
|
bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 20, 2026
Show that every semimodule over an ordered semiring is a convex space. It is sadly impossible to make this a global instance since it creates diamonds with structural instances such as `ConvexSpace R X → ConvexSpace R Y → ConvexSpace R (X × Y)` because `(∑ i, f i).fst = ∑ i, (f i).fst` isn't defeq, ultimately because `Finset.sum` isn't a field of `AddCommMonoid`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
RaggedR
pushed a commit
to RaggedR/mathlib4
that referenced
this pull request
May 22, 2026
…y#39531) Show that every semimodule over an ordered semiring is a convex space. It is sadly impossible to make this a global instance since it creates diamonds with structural instances such as `ConvexSpace R X → ConvexSpace R Y → ConvexSpace R (X × Y)` because `(∑ i, f i).fst = ∑ i, (f i).fst` isn't defeq, ultimately because `Finset.sum` isn't a field of `AddCommMonoid`.
b-mehta
pushed a commit
to b-mehta/mathlib4
that referenced
this pull request
Jun 2, 2026
…y#39531) Show that every semimodule over an ordered semiring is a convex space. It is sadly impossible to make this a global instance since it creates diamonds with structural instances such as `ConvexSpace R X → ConvexSpace R Y → ConvexSpace R (X × Y)` because `(∑ i, f i).fst = ∑ i, (f i).fst` isn't defeq, ultimately because `Finset.sum` isn't a field of `AddCommMonoid`.
Bergschaf
pushed a commit
to Bergschaf/mathlib4
that referenced
this pull request
Jun 3, 2026
…y#39531) Show that every semimodule over an ordered semiring is a convex space. It is sadly impossible to make this a global instance since it creates diamonds with structural instances such as `ConvexSpace R X → ConvexSpace R Y → ConvexSpace R (X × Y)` because `(∑ i, f i).fst = ∑ i, (f i).fst` isn't defeq, ultimately because `Finset.sum` isn't a field of `AddCommMonoid`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show that every semimodule over an ordered semiring is a convex space.
It is sadly impossible to make this a global instance since it creates diamonds with structural instances such as
ConvexSpace R X → ConvexSpace R Y → ConvexSpace R (X × Y)because(∑ i, f i).fst = ∑ i, (f i).fstisn't defeq, ultimately becauseFinset.sumisn't a field ofAddCommMonoid.