Skip to content

feat(Mathlib/Data/Finite/Units): Units are (in)finite if type is (in)finite#39569

Open
AlexBrodbelt wants to merge 28 commits into
leanprover-community:masterfrom
AlexBrodbelt:AlexBrodbelt/Data/Finite/Units
Open

feat(Mathlib/Data/Finite/Units): Units are (in)finite if type is (in)finite#39569
AlexBrodbelt wants to merge 28 commits into
leanprover-community:masterfrom
AlexBrodbelt:AlexBrodbelt/Data/Finite/Units

Conversation

@AlexBrodbelt

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label May 19, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label May 19, 2026
@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

PR summary 0628928cc9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Data.Finite.Option (new file) 486
Mathlib.Data.Finite.Subtype (new file) 487
Mathlib.Data.Finite.Units (new file) 500

Declarations diff

+ Option.finite_iff
+ Subtype.finite_ne_iff
+ Units.finite_iff₀
+ Units.infinite_iff₀
+ instance {G : Type*} [GroupWithZero G] [hG : Infinite G] : Infinite Gˣ

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 19, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant