chore(Data/Finsupp): make mapDomain_congr congr

[YaelDillies]

This makes simp stronger. It particular, it breaks some proofs that relied on simp being weak.

From MeanFourier

---

[github-actions]

PR summary 70ae40eade

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff (regex)

+ coe_id
+ mapDomain_fun_comp

You can run this locally as follows

## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 70ae40e).

• +3 new declarations
• −0 removed declarations

+Finsupp.mapDomain_fun_comp
+Finsupp.mapDomain_fun_id
+Representation.IntertwiningMap.coe_id

---

Increase in strong tech debt: (relative, absolute) = (1.00, 0.04)

Current number	Change	Type (strong)
25	1	disabled simpNF lints

No changes to weak technical debt.

Current commit 70ae40eade
Reference commit ae861491c1

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[mathlib-merge-conflicts]

This pull request has conflicts, please merge master and resolve them.

[mathlib-merge-conflicts]

This pull request has conflicts, please merge master and resolve them.

[eric-wieser]

What motivated this?

[YaelDillies]

This makes the simp set more confluent. Otherwise simp fails to prove reindexFinsetRange_repr because the new congr lemma allows it to simplify the inside of the expression further earlier

[eric-wieser]

Why isn't this true? It looks to me like the congr lemma would eta-expand id, which leads to that chain.

[eric-wieser]

(I wonder if simp high would be more appropriate to silence the linter)

[YaelDillies]

I already tried simp high and simp\d a while ago and neither worked to silence the linter.

[eric-wieser]

Can you elaborate on "this isn't true (at least within most of mathlib)"?

[YaelDillies]

@[to_fun mapDomain_fun_id]
lemma mapDomain_id : mapDomain id v = v := sum_single _

/--
info: -- Found 0 errors in 41 declarations (plus 22 automatically generated ones) in the current file with 15 linters


-- All linting checks passed!
-/
#guard_msgs in
#lint

but if I do it with import Mathlib, then it complains. I tried bisecting quickly and I seem to be able to import most of mathlib without complaining

[joneugster]

Thanks, LGTM!

maintainer merge

[github-actions]

🚀 Pull request has been placed on the maintainer queue by joneugster.