Skip to content

[Merged by Bors] - chore(CategoryTheory/Limits): rename mkFanLimit to Fan.IsLimit.mk#39580

Closed
chrisflav wants to merge 1 commit into
leanprover-community:masterfrom
chrisflav:fix-fanlimitmk
Closed

[Merged by Bors] - chore(CategoryTheory/Limits): rename mkFanLimit to Fan.IsLimit.mk#39580
chrisflav wants to merge 1 commit into
leanprover-community:masterfrom
chrisflav:fix-fanlimitmk

Conversation

@chrisflav

Copy link
Copy Markdown
Member

This change makes Fan follow the ConeType.IsLimit.mk naming scheme that we use elsewhere. We do the same for Cofans.


Open in Gitpod

@chrisflav chrisflav added the t-category-theory Category theory label May 19, 2026
@github-actions

Copy link
Copy Markdown

PR summary a5cdd41765

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Cofan.IsColimit.mk
+ Fan.IsLimit.mk

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@robin-carlier

Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 20, 2026
@joelriou

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request May 20, 2026
…#39580)

This change makes `Fan` follow the `ConeType.IsLimit.mk` naming scheme that we use elsewhere. We do the same for `Cofan`s.
@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 20, 2026
@mathlib-bors

mathlib-bors Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(CategoryTheory/Limits): rename mkFanLimit to Fan.IsLimit.mk [Merged by Bors] - chore(CategoryTheory/Limits): rename mkFanLimit to Fan.IsLimit.mk May 20, 2026
@mathlib-bors mathlib-bors Bot closed this May 20, 2026
RaggedR pushed a commit to RaggedR/mathlib4 that referenced this pull request May 22, 2026
…leanprover-community#39580)

This change makes `Fan` follow the `ConeType.IsLimit.mk` naming scheme that we use elsewhere. We do the same for `Cofan`s.
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
…leanprover-community#39580)

This change makes `Fan` follow the `ConeType.IsLimit.mk` naming scheme that we use elsewhere. We do the same for `Cofan`s.
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…leanprover-community#39580)

This change makes `Fan` follow the `ConeType.IsLimit.mk` naming scheme that we use elsewhere. We do the same for `Cofan`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants