refactor: change definition of restricted power series to align with restricted multivariate power series#39583
Conversation
PR summary e239c1e0ed
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.PowerSeries.Restricted | 1695 | 1582 | -113 (-6.67%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.PowerSeries.Restricted |
-113 |
Declarations diff (regex)
+ addSubgroup
+ isRestricted.add
+ isRestricted.mul
+ isRestricted.neg
+ isRestricted_C
+ isRestricted_abs_iff
+ isRestricted_comp_uniqueEquiv
+ isRestricted_iff'
+ isRestricted_monomial
+ isRestricted_one
+ isRestricted_zero
+ subring
- C
- add
- convergenceSet
- convergenceSet_BddAbove
- isRestricted_iff_abs
- monomial
- mul
- neg
- one
- smul
- zero
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
e239c1e).
- +12 new declarations
- −12 removed declarations
-PowerSeries.IsRestricted.C
-PowerSeries.IsRestricted.add
+PowerSeries.IsRestricted.addSubgroup
-PowerSeries.IsRestricted.convergenceSet
-PowerSeries.IsRestricted.convergenceSet_BddAbove
-PowerSeries.IsRestricted.isRestricted_iff
-PowerSeries.IsRestricted.isRestricted_iff_abs
-PowerSeries.IsRestricted.monomial
-PowerSeries.IsRestricted.mul
-PowerSeries.IsRestricted.neg
-PowerSeries.IsRestricted.one
-PowerSeries.IsRestricted.smul
+PowerSeries.IsRestricted.subring
-PowerSeries.IsRestricted.zero
+PowerSeries.isRestricted.add
+PowerSeries.isRestricted.mul
+PowerSeries.isRestricted.neg
+PowerSeries.isRestricted_C
+PowerSeries.isRestricted_abs_iff
+PowerSeries.isRestricted_iff
+PowerSeries.isRestricted_iff'
+PowerSeries.isRestricted_monomial
+PowerSeries.isRestricted_one
+PowerSeries.isRestricted_zeroDecrease in strong tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type (strong) |
|---|---|---|
| 391 | -1 | adaptation notes |
Current commit e239c1e0ed
Reference commit 5f6fd26f8a
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
This pull request is now in draft mode. No active bors state needed cleanup. While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like |
5b2d922 to
adab8ec
Compare
|
This pull request has conflicts, please merge |
|
This PR/issue depends on:
|
|
This pull request has conflicts, please merge |
| lemma isRestricted_iff (c : ℝ) (f : PowerSeries R) : | ||
| IsRestricted c f ↔ Tendsto (fun (t : ℕ) ↦ ‖coeff t f‖ * c ^ t) cofinite (𝓝 0) := by | ||
| rw [IsRestricted, MvPowerSeries.IsRestricted, isRestricted_comp_uniqueEquiv] | ||
| exact ⟨fun H => (H.comp (Finsupp.uniqueEquiv ()).symm.injective.tendsto_cofinite).congr fun n => |
There was a problem hiding this comment.
| exact ⟨fun H => (H.comp (Finsupp.uniqueEquiv ()).symm.injective.tendsto_cofinite).congr fun n => | |
| exact ⟨fun H ↦ (H.comp (Finsupp.uniqueEquiv ()).symm.injective.tendsto_cofinite).congr fun n ↦ |
Can you check this everywhere?
| open Filter | ||
| open scoped Topology Pointwise | ||
|
|
||
| variable {R : Type*} [NormedRing R] |
There was a problem hiding this comment.
| variable {R : Type*} [NormedRing R] | |
| variable {R : Type*} [NormedRing R] (c : ℝ) (f : PowerSeries R) |
Then you can remove it everywhere else.
| calc _ ≤ ‖(coeff i) f‖ * |c ^ i| := by bound | ||
| _ ≤ 1 := by simpa using (hf i h).le | ||
| /-- Restricted power series as an additive subgroup of `PowerSeries R`. -/ | ||
| def addSubgroup (c : ℝ) : AddSubgroup (PowerSeries R) where |
There was a problem hiding this comment.
I am not 100% it works, but can you to use MvPowerSeries.IsRestricted.addSubgroup directly?
| end IsRestricted | ||
| end PowerSeries | ||
| /-- Restricted power series as an subring of `PowerSeries R`. -/ | ||
| def subring (c : ℝ) : Subring (PowerSeries R) where |
Previously, restricted power series were defined in terms of a
tendsto atTopthis has been changed to be an abbrev ofMvPowerSeries.IsRestrictedwithisRestricted_ifflemmas to convert to nicer usable definitions.