feat: experimental hack to allow by finiteness auto-params#39596
Open
grunweg wants to merge 1 commit into
Open
feat: experimental hack to allow by finiteness auto-params#39596grunweg wants to merge 1 commit into
grunweg wants to merge 1 commit into
Conversation
PR summary 55d0c0d87d
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.ENNReal.Basic | 725 | 726 | +1 (+0.14%) |
Import changes for all files
| Files | Import difference |
|---|---|
5 filesMathlib.Analysis.Normed.Lp.WithLp Mathlib.Data.ENNReal.Basic Mathlib.Data.ENNReal.Lemmas Mathlib.Data.ENNReal.Real Mathlib.Data.Real.ENatENNReal |
1 |
Declarations diff
+ autofinite
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to strong technical debt.
No changes to weak technical debt.
Contributor
Author
|
Actually, #39333 may be a better solution here. That will not require modifying any existing auto-params. Using the discharger as in that PR may break proofs (where previously In the future, if simp's default discharger were changed to this discharger, that would simplify live in mathlib greatly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a way to apply
by finitenessauto-parameters in simp lemmas.(Making simp run dischargers natively requires unfortunate hacks... so is not easily doable.)
Another alternative: make a simproc to run auto-params in general. This might be even better.
Written at the Mathlib Initiative Retreat. Thanks to Joachim Breitner and Henrik Böving for the help writing this!
The hack is calling
runTactic: iffiniteness(and, hence,aesop) could be called from an appropriate meta function instead, we could make the implementation more robust.