Skip to content

Don't look up!#39597

Open
grunweg wants to merge 703 commits into
leanprover-community:masterfrom
grunweg:experiements-miretreat
Open

Don't look up!#39597
grunweg wants to merge 703 commits into
leanprover-community:masterfrom
grunweg:experiements-miretreat

Conversation

@grunweg

@grunweg grunweg commented May 19, 2026

Copy link
Copy Markdown
Contributor

Open in Gitpod

hrmacbeth and others added 25 commits May 16, 2026 04:27
I’m really not sure we want this. I only push this discussion
It's getting really clean now... is the notation clear enough?
- we can also make mfderiv_smul private
- as a matter of fact, half our smul lemmas are now superfluous, given that
  we can hide behind the mvfderiv abstraction! \o/

- also use mvfderiv instead of open-coding it in CovariantDerivative/Trivial
@github-actions github-actions Bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-differential-geometry Manifolds etc labels May 19, 2026
@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

error: the PR title does not contain a colon
Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

  • feat (feature)
  • fix (bug fix)
  • doc (documentation)
  • style (formatting, missing semicolons, ...)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)
  • perf (performance improvement, optimization, ...)
  • ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

  • Data/Nat/Basic
  • Algebra/Group/Defs
  • Topology/Constructions

<subject> has the following constraints:

  • do not capitalize the first letter
  • no dot(.) at the end
  • use imperative, present tense: "change" not "changed" nor "changes"

@grunweg grunweg added the WIP Work in progress label May 19, 2026
@grunweg grunweg changed the title Experiements miretreat Don't look up! May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-differential-geometry Manifolds etc WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants