Don't look up!#39597
Open
grunweg wants to merge 703 commits into
Open
Conversation
grunweg
commented
May 19, 2026
Contributor
They will be refactored later anyway.
I’m really not sure we want this. I only push this discussion
It's getting really clean now... is the notation clear enough?
- we can also make mfderiv_smul private - as a matter of fact, half our smul lemmas are now superfluous, given that we can hide behind the mvfderiv abstraction! \o/ - also use mvfderiv instead of open-coding it in CovariantDerivative/Trivial
🚨 PR Title Needs FormattingPlease update the title to match our commit style conventions. Errors from script: Details on the required title formatThe title should fit the following format:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.