Skip to content

[Merged by Bors] - chore(Topology/Compactness/CountablyCompact): generalize theorem#39600

Closed
plp127 wants to merge 5 commits into
leanprover-community:masterfrom
plp127:aliu/inducing-free
Closed

[Merged by Bors] - chore(Topology/Compactness/CountablyCompact): generalize theorem#39600
plp127 wants to merge 5 commits into
leanprover-community:masterfrom
plp127:aliu/inducing-free

Conversation

@plp127

@plp127 plp127 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Generalize theorem Topology.IsEmbedding.isSeqCompact_iff to Topology.IsInducing.isSeqCompact_iff by replacing IsEmbedding by IsInducing.

Also fix capitalization error.


Open in Gitpod

@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label May 19, 2026
@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

PR summary 7b9b73e717

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ LindelofSpace.compactSpace
+ Topology.IsInducing.isSeqCompact_iff
- Topology.IsEmbedding.isSeqCompact_iff

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 7b9b73e717
Reference commit 45edb79497

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Topology/Compactness/CountablyCompact.lean
@plp127 plp127 added the awaiting-author A reviewer has asked the author a question or requested changes. label May 22, 2026
@plp127 plp127 removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 23, 2026
@grunweg

grunweg commented May 26, 2026

Copy link
Copy Markdown
Contributor

Thanks! This looks straightforward, except for the deprecation question. (I think either way is probably fine.)
If a second maintainer feels strongly, I'll let them comment within the next 24h (and otherwise merge myself).
maintainer merge?

@j-loreaux

j-loreaux commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@plp127 I think the material is new enough and the chance be being bitten by this particular deprecation rare enough, that it doesn't matter whether or not we add the deprecation (for IsInducing). I'll leave it up to you.

bors d+

@mathlib-bors

mathlib-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

✌️ plp127 can now approve this pull request until 2026-06-17 02:44 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 3, 2026
@plp127

plp127 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Jun 3, 2026
)

Generalize theorem `Topology.IsEmbedding.isSeqCompact_iff` to `Topology.IsInducing.isSeqCompact_iff` by replacing `IsEmbedding` by `IsInducing`.

Also fix capitalization error.
@mathlib-bors

mathlib-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Topology/Compactness/CountablyCompact): generalize theorem [Merged by Bors] - chore(Topology/Compactness/CountablyCompact): generalize theorem Jun 3, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 3, 2026
@plp127
plp127 deleted the aliu/inducing-free branch June 3, 2026 19:15
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…nprover-community#39600)

Generalize theorem `Topology.IsEmbedding.isSeqCompact_iff` to `Topology.IsInducing.isSeqCompact_iff` by replacing `IsEmbedding` by `IsInducing`.

Also fix capitalization error.
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…nprover-community#39600)

Generalize theorem `Topology.IsEmbedding.isSeqCompact_iff` to `Topology.IsInducing.isSeqCompact_iff` by replacing `IsEmbedding` by `IsInducing`.

Also fix capitalization error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants