Skip to content

[Merged by Bors] - feat(LinearAlgebra/Matrix/Charpoly/Eigs): generalize to CommRings#39601

Closed
SnirBroshi wants to merge 1 commit into
leanprover-community:masterfrom
SnirBroshi:feature/matrix/charpoly-roots-eigenvalues-rings
Closed

[Merged by Bors] - feat(LinearAlgebra/Matrix/Charpoly/Eigs): generalize to CommRings#39601
SnirBroshi wants to merge 1 commit into
leanprover-community:masterfrom
SnirBroshi:feature/matrix/charpoly-roots-eigenvalues-rings

Conversation

@SnirBroshi

Copy link
Copy Markdown
Collaborator

Also adds r ∈ spectrum R B ↔ ¬IsUnit (B.charpoly.eval r) which is the ring version of r ∈ spectrum K A ↔ A.charpoly.IsRoot r.


The variables above define A over a Field and B over a CommRing, switching A to B generalizes.

Open in Gitpod

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 20, 2026
@github-actions

Copy link
Copy Markdown

PR summary ad4f90556a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mem_spectrum_iff_not_isUnit_eval_charpoly

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@b-mehta

b-mehta commented May 20, 2026

Copy link
Copy Markdown
Contributor

This looks good to me but it's not my area so

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by b-mehta.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 20, 2026
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 23, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 23, 2026
…39601)

Also adds `r ∈ spectrum R B ↔ ¬IsUnit (B.charpoly.eval r)` which is the ring version of `r ∈ spectrum K A ↔ A.charpoly.IsRoot r`.
@mathlib-bors

mathlib-bors Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(LinearAlgebra/Matrix/Charpoly/Eigs): generalize to CommRings [Merged by Bors] - feat(LinearAlgebra/Matrix/Charpoly/Eigs): generalize to CommRings May 23, 2026
@mathlib-bors mathlib-bors Bot closed this May 23, 2026
RaggedR pushed a commit to RaggedR/mathlib4 that referenced this pull request May 24, 2026
…eanprover-community#39601)

Also adds `r ∈ spectrum R B ↔ ¬IsUnit (B.charpoly.eval r)` which is the ring version of `r ∈ spectrum K A ↔ A.charpoly.IsRoot r`.
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
…eanprover-community#39601)

Also adds `r ∈ spectrum R B ↔ ¬IsUnit (B.charpoly.eval r)` which is the ring version of `r ∈ spectrum K A ↔ A.charpoly.IsRoot r`.
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…eanprover-community#39601)

Also adds `r ∈ spectrum R B ↔ ¬IsUnit (B.charpoly.eval r)` which is the ring version of `r ∈ spectrum K A ↔ A.charpoly.IsRoot r`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants