-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Merged by Bors] - chore(Mathlib/Tactic): stop norm_num importing the Bochner integral #39602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6e844be
chore(Mathlib/Tactic): stop norm_num importing the Bochner integral
b-mehta ef6aaa9
oops
b-mehta c6776c8
make it not weird
b-mehta 68dd1fa
mk all
b-mehta b18c1c4
Merge branch 'master' into norm-num-bochner
grunweg 4760b45
add module doc
b-mehta 0b96e6b
add assert_not_exists to prevent future regression
b-mehta 3f8be6e
fix imports
b-mehta 41c067a
move file per MSB's suggestion
b-mehta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /- | ||
| Copyright (c) 2022 Michael Stoll. All rights reserved. | ||
| Released under Apache 2.0 license as described in the file LICENSE. | ||
| Authors: Michael Stoll | ||
| -/ | ||
| module | ||
|
|
||
| public import Mathlib.Analysis.Complex.Polynomial.Basic | ||
| public import Mathlib.NumberTheory.LegendreSymbol.AddCharacter | ||
|
|
||
| /-! | ||
| # Additive characters on finite fields | ||
|
|
||
| We construct a primitive additive character on a finite field `F` with values in `ℂ`. | ||
| This file is kept separate from `Mathlib.NumberTheory.LegendreSymbol.AddCharacter` to avoid | ||
| importing the fundamental theorem of algebra and Bochner integral into that file. | ||
| -/ | ||
|
|
||
|
b-mehta marked this conversation as resolved.
|
||
| namespace AddChar | ||
|
|
||
| section Field | ||
|
|
||
| variable (F : Type*) [Field F] [Finite F] | ||
|
|
||
| lemma ringChar_ne : ringChar ℂ ≠ ringChar F := by | ||
| simpa only [ringChar.eq_zero] using (CharP.ringChar_ne_zero_of_finite F).symm | ||
|
|
||
| /-- A primitive additive character on the finite field `F` with values in `ℂ`. -/ | ||
| public noncomputable def FiniteField.primitiveChar_to_Complex : AddChar F ℂ := by | ||
| letI ch := primitiveChar F ℂ <| by exact ringChar_ne F | ||
| refine MonoidHom.compAddChar ?_ ch.char | ||
| exact (IsCyclotomicExtension.algEquiv {(ch.n : ℕ)} ℂ (CyclotomicField ch.n ℂ) ℂ).toMonoidHom | ||
|
|
||
| public lemma FiniteField.primitiveChar_to_Complex_isPrimitive : | ||
| (primitiveChar_to_Complex F).IsPrimitive := by | ||
| refine IsPrimitive.compMulHom_of_isPrimitive (PrimitiveAddChar.prim _) ?_ | ||
| let nn := (primitiveChar F ℂ <| ringChar_ne F).n | ||
| exact (IsCyclotomicExtension.algEquiv {(nn : ℕ)} ℂ (CyclotomicField nn ℂ) ℂ).injective | ||
|
|
||
| end Field | ||
|
|
||
| end AddChar | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.