Skip to content

[Merged by Bors] - doc: add docstrings for reversed range telescoping lemmas#39605

Closed
Qinghev wants to merge 1 commit into
leanprover-community:masterfrom
Qinghev:qinghev/doc-sum-range-sub-prime
Closed

[Merged by Bors] - doc: add docstrings for reversed range telescoping lemmas#39605
Qinghev wants to merge 1 commit into
leanprover-community:masterfrom
Qinghev:qinghev/doc-sum-range-sub-prime

Conversation

@Qinghev

@Qinghev Qinghev commented May 20, 2026

Copy link
Copy Markdown
Contributor

This PR adds docstrings for two existing Finset telescoping lemmas and their additive versions generated by to_additive:

  • Finset.prod_range_div' / Finset.sum_range_sub'
  • Finset.eq_prod_range_div / Finset.eq_sum_range_sub

It is documentation-only: no declarations or imports are changed.

CI has passed.

AI assistance: Codex was used to help inspect the public PR/CI status and update this PR description.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label May 20, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

PR summary 9cdd822a92

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 9cdd822a92
Reference commit 7403500b02

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 20, 2026
@Qinghev
Qinghev marked this pull request as ready for review May 20, 2026 11:40
@mathlib-triage mathlib-triage Bot assigned joneugster and unassigned themathqueen Jul 7, 2026
@joneugster joneugster assigned joneugster and unassigned joneugster Jul 17, 2026
@joneugster joneugster added the documentation Improvements or additions to documentation label Jul 17, 2026

@joneugster joneugster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@joneugster joneugster added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 17, 2026
@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by joneugster.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 17, 2026
@j-loreaux

Copy link
Copy Markdown
Contributor

bors merge

@j-loreaux j-loreaux closed this Jul 17, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Already running a review

@j-loreaux j-loreaux reopened this Jul 17, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 17, 2026
@j-loreaux

Copy link
Copy Markdown
Contributor

oops, misclick.

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 17, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 17, 2026
This PR adds docstrings for two existing `Finset` telescoping lemmas and their additive versions generated by `to_additive`:

* `Finset.prod_range_div'` / `Finset.sum_range_sub'`
* `Finset.eq_prod_range_div` / `Finset.eq_sum_range_sub`

It is documentation-only: no declarations or imports are changed.

CI has passed.

AI assistance: Codex was used to help inspect the public PR/CI status and update this PR description.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@j-loreaux j-loreaux changed the title Add docstrings for reversed range telescoping lemmas doc: add docstrings for reversed range telescoping lemmas Jul 17, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title doc: add docstrings for reversed range telescoping lemmas [Merged by Bors] - doc: add docstrings for reversed range telescoping lemmas Jul 17, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants