Skip to content

[Merged by Bors] - feat: drop completeness assumption in the definition of setToFun, expand API#39615

Closed
sgouezel wants to merge 7 commits into
leanprover-community:masterfrom
sgouezel:SG_noComplete
Closed

[Merged by Bors] - feat: drop completeness assumption in the definition of setToFun, expand API#39615
sgouezel wants to merge 7 commits into
leanprover-community:masterfrom
sgouezel:SG_noComplete

Conversation

@sgouezel

@sgouezel sgouezel commented May 20, 2026

Copy link
Copy Markdown
Contributor

The definition of the Bochner integral and the vector measure integral handle the non-completeness of the space in a completely parallel way. To avoid duplication and streamline proofs, we move this handling of non-completeness one step higher, to the definition of setToFun. We also expand its API -- this is cherry-picked from a work on vector measure integrals that has highlighted the need for the lemmas I am adding here.

To minimize the size of the PR, I went for minimal fixes in the files on Bochner integrals and on conditional expectations. Further cleanup will be done in subsequent PRs.


Open in Gitpod

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

PR summary c02c766436

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.MeasureTheory.SimpleFunc.toLp
+ enorm_setToFun_le
+ norm_setToFun_le_toReal
+ norm_toL1_eq_lintegral_enorm
+ setToFun_add_left''
+ setToFun_congr_smul_measure'
+ setToFun_of_le_map
+ setToFun_of_le_map_of_stronglyMeasurable
+ setToFun_simpleFunc
- toLp

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the t-measure-probability Measure theory / Probability theory label May 20, 2026

@RemyDegenne RemyDegenne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors d+

0 if the function is not integrable. -/
def setToFun (hT : DominatedFinMeasAdditive μ T C) (f : α → E) : F :=
if hf : Integrable f μ then L1.setToL1 hT (hf.toL1 f) else 0
if _hF : CompleteSpace F then

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docstring to mention that new if condition.

@mathlib-bors

mathlib-bors Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label May 21, 2026
Comment thread Mathlib/MeasureTheory/Integral/SetToL1.lean Outdated
@sgouezel

Copy link
Copy Markdown
Contributor Author

bors r+
Thanks for the review!

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 21, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 21, 2026
…xpand API (#39615)

The definition of the Bochner integral and the vector measure integral handle the non-completeness of the space in a completely parallel way. To avoid duplication and streamline proofs, we move this handling of non-completeness one step higher, to the definition of `setToFun`. We also expand its API -- this is cherry-picked from a work on vector measure integrals that has highlighted the need for the lemmas I am adding here.

To minimize the size of the PR, I went for minimal fixes in the files on Bochner integrals and on conditional expectations. Further cleanup will be done in subsequent PRs.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@mathlib-bors

mathlib-bors Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat: drop completeness assumption in the definition of setToFun, expand API [Merged by Bors] - feat: drop completeness assumption in the definition of setToFun, expand API May 21, 2026
@mathlib-bors mathlib-bors Bot closed this May 21, 2026
RaggedR pushed a commit to RaggedR/mathlib4 that referenced this pull request May 22, 2026
…xpand API (leanprover-community#39615)

The definition of the Bochner integral and the vector measure integral handle the non-completeness of the space in a completely parallel way. To avoid duplication and streamline proofs, we move this handling of non-completeness one step higher, to the definition of `setToFun`. We also expand its API -- this is cherry-picked from a work on vector measure integrals that has highlighted the need for the lemmas I am adding here.

To minimize the size of the PR, I went for minimal fixes in the files on Bochner integrals and on conditional expectations. Further cleanup will be done in subsequent PRs.
mathlib-bors Bot pushed a commit that referenced this pull request May 26, 2026
…on (#39862)

This is not interesting from a mathematical point of view (in all reasonable applications, the spaces are complete), but it is a direct byproduct of the change to `setToFun` in #39615, and it means that whenever we write conditional expectations the job of Lean is easier (as it doesn't have to look for completeness) and the resulting term is simpler.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
…xpand API (leanprover-community#39615)

The definition of the Bochner integral and the vector measure integral handle the non-completeness of the space in a completely parallel way. To avoid duplication and streamline proofs, we move this handling of non-completeness one step higher, to the definition of `setToFun`. We also expand its API -- this is cherry-picked from a work on vector measure integrals that has highlighted the need for the lemmas I am adding here.

To minimize the size of the PR, I went for minimal fixes in the files on Bochner integrals and on conditional expectations. Further cleanup will be done in subsequent PRs.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
…on (leanprover-community#39862)

This is not interesting from a mathematical point of view (in all reasonable applications, the spaces are complete), but it is a direct byproduct of the change to `setToFun` in leanprover-community#39615, and it means that whenever we write conditional expectations the job of Lean is easier (as it doesn't have to look for completeness) and the resulting term is simpler.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…xpand API (leanprover-community#39615)

The definition of the Bochner integral and the vector measure integral handle the non-completeness of the space in a completely parallel way. To avoid duplication and streamline proofs, we move this handling of non-completeness one step higher, to the definition of `setToFun`. We also expand its API -- this is cherry-picked from a work on vector measure integrals that has highlighted the need for the lemmas I am adding here.

To minimize the size of the PR, I went for minimal fixes in the files on Bochner integrals and on conditional expectations. Further cleanup will be done in subsequent PRs.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…on (leanprover-community#39862)

This is not interesting from a mathematical point of view (in all reasonable applications, the spaces are complete), but it is a direct byproduct of the change to `setToFun` in leanprover-community#39615, and it means that whenever we write conditional expectations the job of Lean is easier (as it doesn't have to look for completeness) and the resulting term is simpler.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@sgouezel
sgouezel deleted the SG_noComplete branch June 9, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants