Skip to content

[Merged by Bors] - refactor(Topology): use WithTopology to define WithConstructibleTopology#39621

Closed
chrisflav wants to merge 3 commits into
leanprover-community:masterfrom
chrisflav:with-constructible-fix
Closed

[Merged by Bors] - refactor(Topology): use WithTopology to define WithConstructibleTopology#39621
chrisflav wants to merge 3 commits into
leanprover-community:masterfrom
chrisflav:with-constructible-fix

Conversation

@chrisflav

Copy link
Copy Markdown
Member

We replace the type synonym WithConstructibleTopology by WithTopology _ (constructibleTopology X). This breaks the def-eq X = WithConstructibleTopology X, which was luckily not abused much yet.


Open in Gitpod

@chrisflav chrisflav added the t-topology Topological spaces, uniform spaces, metric spaces, filters label May 20, 2026
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

PR summary 80da5d5662

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Function.Surjective.compactSpace
+ WithConstructibleTopology.isClosed_iff
+ WithConstructibleTopology.isOpen_iff
+ continuous_ofTopology
+ continuous_toTopology
+ isClosed_iff
+ isOpen_iff
- instance : TopologicalSpace (WithConstructibleTopology X)

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 80da5d5662
Reference commit 34e41cb1b0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Topology/Compactness/Compact.lean Outdated

@j-loreaux j-loreaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors

mathlib-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

✌️ chrisflav can now approve this pull request until 2026-06-17 03:03 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

@chrisflav

Copy link
Copy Markdown
Member Author

Thanks for the reviews!
bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Jun 3, 2026
…pology` (#39621)

We replace the type synonym `WithConstructibleTopology` by `WithTopology _ (constructibleTopology X)`. This breaks the def-eq `X = WithConstructibleTopology X`, which was luckily not abused much yet.
@mathlib-bors

mathlib-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(Topology): use WithTopology to define WithConstructibleTopology [Merged by Bors] - refactor(Topology): use WithTopology to define WithConstructibleTopology Jun 3, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 3, 2026
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…pology` (leanprover-community#39621)

We replace the type synonym `WithConstructibleTopology` by `WithTopology _ (constructibleTopology X)`. This breaks the def-eq `X = WithConstructibleTopology X`, which was luckily not abused much yet.
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…pology` (leanprover-community#39621)

We replace the type synonym `WithConstructibleTopology` by `WithTopology _ (constructibleTopology X)`. This breaks the def-eq `X = WithConstructibleTopology X`, which was luckily not abused much yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants