[Merged by Bors] - feat: add ofScientific lemmas for Complex/RCLike/Quaternion#39628
Closed
eric-wieser wants to merge 6 commits into
Closed
[Merged by Bors] - feat: add ofScientific lemmas for Complex/RCLike/Quaternion#39628eric-wieser wants to merge 6 commits into
ofScientific lemmas for Complex/RCLike/Quaternion#39628eric-wieser wants to merge 6 commits into
Conversation
eric-wieser
commented
May 20, 2026
Member
PR summary a8fe9f2082Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
eric-wieser
commented
May 20, 2026
ofScientific lemmas for ComplexofScientific lemmas for Complex/RCLike/Quaternion
ocfnash
approved these changes
May 25, 2026
Comment on lines
+1176
to
+1186
| section ofScientific | ||
| open OfScientific (ofScientific) | ||
| variable (m : ℕ) (s : Bool) (e : ℕ) | ||
|
|
||
| @[norm_cast] lemma coe_ofScientific : ((ofScientific m s e : R) : ℍ[R]) = ofScientific m s e := rfl | ||
| @[simp] lemma re_ofScientific : (ofScientific m s e : ℍ[R]).re = ofScientific m s e := rfl | ||
| @[simp] lemma imI_ofScientific : (ofScientific m s e : ℍ[R]).imI = 0 := rfl | ||
| @[simp] lemma imJ_ofScientific : (ofScientific m s e : ℍ[R]).imJ = 0 := rfl | ||
| @[simp] lemma imK_ofScientific : (ofScientific m s e : ℍ[R]).imK = 0 := rfl | ||
|
|
||
| end ofScientific |
Contributor
There was a problem hiding this comment.
It's quite hard to think of how we'd ever use these but I guess they're very cheap to add / maintain.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
ofScientific lemmas for Complex/RCLike/QuaternionofScientific lemmas for Complex/RCLike/Quaternion
b-mehta
pushed a commit
to b-mehta/mathlib4
that referenced
this pull request
Jun 2, 2026
Bergschaf
pushed a commit
to Bergschaf/mathlib4
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.