Skip to content

[Merged by Bors] - feat: add ofScientific lemmas for Complex/RCLike/Quaternion#39628

Closed
eric-wieser wants to merge 6 commits into
leanprover-community:masterfrom
eric-wieser:ofScientific
Closed

[Merged by Bors] - feat: add ofScientific lemmas for Complex/RCLike/Quaternion#39628
eric-wieser wants to merge 6 commits into
leanprover-community:masterfrom
eric-wieser:ofScientific

Conversation

@eric-wieser

Copy link
Copy Markdown
Member

Open in Gitpod

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

PR summary a8fe9f2082

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_ofScientific
+ imI_ofScientific
+ imJ_ofScientific
+ imK_ofScientific
+ im_ofScientific
+ ofScientific_im
+ ofScientific_re
++ ofReal_ofScientific
++ re_ofScientific

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label May 20, 2026
@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label May 20, 2026
Comment thread Mathlib/Analysis/RCLike/Basic.lean
@eric-wieser eric-wieser changed the title feat: add ofScientific lemmas for Complex feat: add ofScientific lemmas for Complex/RCLike/Quaternion May 20, 2026
@eric-wieser
eric-wieser requested a review from ocfnash May 25, 2026 15:39

@ocfnash ocfnash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

Comment on lines +1176 to +1186
section ofScientific
open OfScientific (ofScientific)
variable (m : ℕ) (s : Bool) (e : ℕ)

@[norm_cast] lemma coe_ofScientific : ((ofScientific m s e : R) : ℍ[R]) = ofScientific m s e := rfl
@[simp] lemma re_ofScientific : (ofScientific m s e : ℍ[R]).re = ofScientific m s e := rfl
@[simp] lemma imI_ofScientific : (ofScientific m s e : ℍ[R]).imI = 0 := rfl
@[simp] lemma imJ_ofScientific : (ofScientific m s e : ℍ[R]).imJ = 0 := rfl
@[simp] lemma imK_ofScientific : (ofScientific m s e : ℍ[R]).imK = 0 := rfl

end ofScientific

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite hard to think of how we'd ever use these but I guess they're very cheap to add / maintain.

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 25, 2026
@mathlib-bors

mathlib-bors Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat: add ofScientific lemmas for Complex/RCLike/Quaternion [Merged by Bors] - feat: add ofScientific lemmas for Complex/RCLike/Quaternion May 25, 2026
@mathlib-bors mathlib-bors Bot closed this May 25, 2026
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants