Skip to content

[Merged by Bors] - feat(RingTheory/Coalgebra/Convolution): Algebra instance on convolution semiring#39629

Closed
hawkrobe wants to merge 15 commits into
leanprover-community:masterfrom
hawkrobe:coalg-convolution-algebra
Closed

[Merged by Bors] - feat(RingTheory/Coalgebra/Convolution): Algebra instance on convolution semiring#39629
hawkrobe wants to merge 15 commits into
leanprover-community:masterfrom
hawkrobe:coalg-convolution-algebra

Conversation

@hawkrobe

@hawkrobe hawkrobe commented May 20, 2026

Copy link
Copy Markdown
Contributor

This PR completes the algebraic structure on the convolution object.


I followed the pattern in Matrix/WithConv.lean which splits out IsScalarTower and SMulCommClass. Used in pre-Lie / Oudom–Guin constructions.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label May 20, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the t-ring-theory Ring theory label May 20, 2026
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

PR summary 4acad02b6c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ convAlgebra
+ convAlgebraMap_apply
+ instance [Monoid S] [DistribMulAction S A] [SMulCommClass R S A] [IsScalarTower S A A] :
+ instance [Monoid S] [DistribMulAction S A] [SMulCommClass R S A] [SMulCommClass S A A] :

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 4acad02).

  • +4 new declarations
  • −0 removed declarations
+LinearMap.convAlgebra
+LinearMap.convAlgebraMap_apply
+LinearMap.instIsScalarTowerWithConvId
+LinearMap.instSMulCommClassWithConvId

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 4acad02b6c
Reference commit 3db20e2c6e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@hawkrobe
hawkrobe force-pushed the coalg-convolution-algebra branch 2 times, most recently from 808ae18 to 019d134 Compare May 20, 2026 20:49
@hawkrobe
hawkrobe force-pushed the coalg-convolution-algebra branch from 019d134 to 9d7441b Compare May 20, 2026 20:50
@hawkrobe hawkrobe changed the title feat(RingTheory/Coalgebra/Convolution): Algebra R on convolution semiring feat(RingTheory/Coalgebra/Convolution): Algebra on convolution semiring May 20, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 5, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

…lgebra

# Conflicts:
#	Mathlib/RingTheory/Coalgebra/Convolution.lean
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 5, 2026
@hawkrobe
hawkrobe temporarily deployed to cache-upload-forks June 5, 2026 01:50 — with GitHub Actions Inactive
@hawkrobe
hawkrobe temporarily deployed to cache-upload-forks June 6, 2026 16:58 — with GitHub Actions Inactive
Comment thread Mathlib/RingTheory/Coalgebra/Convolution.lean Outdated
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
@hawkrobe hawkrobe changed the title feat(RingTheory/Coalgebra/Convolution): Algebra on convolution semiring feat(RingTheory/Coalgebra/Convolution): Algebra instance on convolution semiring Jun 9, 2026

@themathqueen themathqueen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this hurts having. Thanks!

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 11, 2026
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request Jun 11, 2026
…tion semiring (#39629)

This PR completes the algebraic structure on the convolution object.
@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 11, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(RingTheory/Coalgebra/Convolution): Algebra instance on convolution semiring [Merged by Bors] - feat(RingTheory/Coalgebra/Convolution): Algebra instance on convolution semiring Jun 11, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 11, 2026
@hawkrobe
hawkrobe deleted the coalg-convolution-algebra branch June 12, 2026 23:15
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Jun 13, 2026
…tion semiring (leanprover-community#39629)

This PR completes the algebraic structure on the convolution object.
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Jun 18, 2026
…tion semiring (leanprover-community#39629)

This PR completes the algebraic structure on the convolution object.
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…tion semiring (leanprover-community#39629)

This PR completes the algebraic structure on the convolution object.
bryangingechen pushed a commit to jcommelin/mathlib4 that referenced this pull request Jun 22, 2026
…tion semiring (leanprover-community#39629)

This PR completes the algebraic structure on the convolution object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants