Skip to content

[Merged by Bors] - chore(SetTheory/Cardinality/Cofinality/Club): use namespace#39641

Closed
vihdzp wants to merge 38 commits into
leanprover-community:masterfrom
vihdzp:clubqf
Closed

[Merged by Bors] - chore(SetTheory/Cardinality/Cofinality/Club): use namespace#39641
vihdzp wants to merge 38 commits into
leanprover-community:masterfrom
vihdzp:clubqf

Conversation

@vihdzp

@vihdzp vihdzp commented May 21, 2026

Copy link
Copy Markdown
Collaborator

I meant to do this in #37677, but forgot to do git push.


Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. t-set-theory Set theory labels May 21, 2026
@github-actions github-actions Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 21, 2026
@vihdzp vihdzp mentioned this pull request May 21, 2026
1 task
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 21, 2026
@github-actions

Copy link
Copy Markdown

PR summary 111f394ed8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.Order.IsNormal.isClub_fixedPoints
+ _root_.Order.IsNormal.isClub_range
+ csSup_mem
+ iInter
+ iInter_of_cof_le_one
+ iInter_of_orderTop
+ inter
+ isLUB_mem
+ of_isEmpty
+ sInter
+ sInter_of_cof_le_one
+ sInter_of_orderTop
+ union
+ univ
- IsClub.csSup_mem
- IsClub.iInter
- IsClub.iInter_of_cof_le_one
- IsClub.iInter_of_orderTop
- IsClub.inter
- IsClub.isLUB_mem
- IsClub.of_isEmpty
- IsClub.sInter
- IsClub.sInter_of_cof_le_one
- IsClub.sInter_of_orderTop
- IsClub.union
- IsClub.univ
- Order.IsNormal.isClub_fixedPoints
- Order.IsNormal.isClub_range

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@vihdzp vihdzp closed this May 23, 2026
@vihdzp vihdzp reopened this May 23, 2026
@kbuzzard

Copy link
Copy Markdown
Member

Thanks for taking the trouble to tidy up!

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 24, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 24, 2026
I meant to do this in #37677, but forgot to do `git push`.
@mathlib-bors

mathlib-bors Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(SetTheory/Cardinality/Cofinality/Club): use namespace [Merged by Bors] - chore(SetTheory/Cardinality/Cofinality/Club): use namespace May 24, 2026
@mathlib-bors mathlib-bors Bot closed this May 24, 2026
@vihdzp
vihdzp deleted the clubqf branch May 24, 2026 14:24
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants