Skip to content

[Merged by Bors] - chore: deprecate Ordinal.natCast_succNat.cast_add_one#39643

Closed
vihdzp wants to merge 1 commit into
leanprover-community:masterfrom
vihdzp:ncs
Closed

[Merged by Bors] - chore: deprecate Ordinal.natCast_succNat.cast_add_one#39643
vihdzp wants to merge 1 commit into
leanprover-community:masterfrom
vihdzp:ncs

Conversation

@vihdzp

@vihdzp vihdzp commented May 21, 2026

Copy link
Copy Markdown
Collaborator

The eventual goal is to write x + 1 instead of succ x.


Open in Gitpod

@vihdzp vihdzp added the t-set-theory Set theory label May 21, 2026
@github-actions

Copy link
Copy Markdown

PR summary 44d323ed88

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@b-mehta

b-mehta commented May 21, 2026

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 21, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 21, 2026
The eventual goal is to write `x + 1` instead of `succ x`.
@mathlib-bors

mathlib-bors Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: deprecate Ordinal.natCast_succNat.cast_add_one [Merged by Bors] - chore: deprecate Ordinal.natCast_succNat.cast_add_one May 21, 2026
@mathlib-bors mathlib-bors Bot closed this May 21, 2026
RaggedR pushed a commit to RaggedR/mathlib4 that referenced this pull request May 22, 2026
…ver-community#39643)

The eventual goal is to write `x + 1` instead of `succ x`.
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
…ver-community#39643)

The eventual goal is to write `x + 1` instead of `succ x`.
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…ver-community#39643)

The eventual goal is to write `x + 1` instead of `succ x`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants