Skip to content

[Merged by Bors] - chore: use x + 1 instead of succ x in Ordinal.limitRecOn#39648

Closed
vihdzp wants to merge 1 commit into
leanprover-community:masterfrom
vihdzp:lim
Closed

[Merged by Bors] - chore: use x + 1 instead of succ x in Ordinal.limitRecOn#39648
vihdzp wants to merge 1 commit into
leanprover-community:masterfrom
vihdzp:lim

Conversation

@vihdzp

@vihdzp vihdzp commented May 21, 2026

Copy link
Copy Markdown
Collaborator

The idea is to phase out the use of Order.succ on ordinals. See also Zulip.


Open in Gitpod

@vihdzp vihdzp added the t-set-theory Set theory label May 21, 2026
@github-actions

Copy link
Copy Markdown

PR summary 81f4fc117c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ add_mul_add_one
+ limitRecOn_add_one

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@urkud

urkud commented May 21, 2026

Copy link
Copy Markdown
Member

Thanks! 🎉
bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 21, 2026
@mathlib-bors

mathlib-bors Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: use x + 1 instead of succ x in Ordinal.limitRecOn [Merged by Bors] - chore: use x + 1 instead of succ x in Ordinal.limitRecOn May 21, 2026
@mathlib-bors mathlib-bors Bot closed this May 21, 2026
RaggedR pushed a commit to RaggedR/mathlib4 that referenced this pull request May 22, 2026
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants