Skip to content

[Merged by Bors] - feat(AlgebraicGeometry/Birational/RationalMap): add RationalMap.representative#39656

Closed
justus-springer wants to merge 1 commit into
leanprover-community:masterfrom
justus-springer:justus/rationalMap_representative
Closed

[Merged by Bors] - feat(AlgebraicGeometry/Birational/RationalMap): add RationalMap.representative#39656
justus-springer wants to merge 1 commit into
leanprover-community:masterfrom
justus-springer:justus/rationalMap_representative

Conversation

@justus-springer

Copy link
Copy Markdown
Collaborator

Split off from #39317


Open in Gitpod

@github-actions

Copy link
Copy Markdown

PR summary 1038f55b36

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ PartialMap.representative_toRationalMap_equiv
+ RationalMap.representative
+ RationalMap.toRationalMap_representative

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@chrisflav chrisflav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no need to make this a separate PR, but anyway: Thanks!

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 21, 2026

@riccardobrasca riccardobrasca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 23, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 23, 2026
@mathlib-bors

mathlib-bors Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(AlgebraicGeometry/Birational/RationalMap): add RationalMap.representative [Merged by Bors] - feat(AlgebraicGeometry/Birational/RationalMap): add RationalMap.representative May 23, 2026
@mathlib-bors mathlib-bors Bot closed this May 23, 2026
RaggedR pushed a commit to RaggedR/mathlib4 that referenced this pull request May 24, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 27, 2026
Add a predicate `RationalMap.IsDominant` and add basic API. This is in preparation for defining composition of rational maps (see #39445). See also [stacks#01RR](https://stacks.math.columbia.edu/tag/01RR).

- [x] depends on: #39316
- [x] depends on: #39656
grunweg pushed a commit to grunweg/mathlib4 that referenced this pull request May 30, 2026
…r-community#39317)

Add a predicate `RationalMap.IsDominant` and add basic API. This is in preparation for defining composition of rational maps (see leanprover-community#39445). See also [stacks#01RR](https://stacks.math.columbia.edu/tag/01RR).

- [x] depends on: leanprover-community#39316
- [x] depends on: leanprover-community#39656
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
…r-community#39317)

Add a predicate `RationalMap.IsDominant` and add basic API. This is in preparation for defining composition of rational maps (see leanprover-community#39445). See also [stacks#01RR](https://stacks.math.columbia.edu/tag/01RR).

- [x] depends on: leanprover-community#39316
- [x] depends on: leanprover-community#39656
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…r-community#39317)

Add a predicate `RationalMap.IsDominant` and add basic API. This is in preparation for defining composition of rational maps (see leanprover-community#39445). See also [stacks#01RR](https://stacks.math.columbia.edu/tag/01RR).

- [x] depends on: leanprover-community#39316
- [x] depends on: leanprover-community#39656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants