Skip to content

[Merged by Bors] - feat(Algebra): add abstract prod_apply and FunLike.coe_prod#39657

Closed
mcdoll wants to merge 7 commits into
leanprover-community:masterfrom
mcdoll:sum_apply
Closed

[Merged by Bors] - feat(Algebra): add abstract prod_apply and FunLike.coe_prod#39657
mcdoll wants to merge 7 commits into
leanprover-community:masterfrom
mcdoll:sum_apply

Conversation

@mcdoll

@mcdoll mcdoll commented May 21, 2026

Copy link
Copy Markdown
Member

Follow-up of #37779, where abstract IsApply classes were introduced. Now, we can prove a generic sum_apply lemma
and in following PRs this will replace specific ones in function spaces.


Open in Gitpod

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 21, 2026
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

PR summary 6575e8668e

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.BigOperators.Pi 548 549 +1 (+0.18%)
Mathlib.Data.Matrix.PEquiv 790 791 +1 (+0.13%)
Mathlib.LinearAlgebra.Matrix.Polynomial 1291 1292 +1 (+0.08%)
Mathlib.LinearAlgebra.QuadraticForm.Dual 1621 1622 +1 (+0.06%)
Mathlib.Analysis.Calculus.FDeriv.Add 1743 1744 +1 (+0.06%)
Import changes for all files
Files Import difference
../mathlib-ci/scripts/pr_summary/import_trans_difference.sh all
There are 3837 files with changed transitive imports taking up over 176703 characters: this is too many to display!
You can run this locally from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci


Declarations diff

+ FunLike.coe_prod
+ prod_apply

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 6575e8668e
Reference commit 041f76daf0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mcdoll mcdoll mentioned this pull request May 21, 2026
29 tasks
@mcdoll mcdoll added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label May 21, 2026
@mcdoll
mcdoll marked this pull request as ready for review May 21, 2026 15:05
@mcdoll mcdoll removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label May 21, 2026
@mcdoll

mcdoll commented May 21, 2026

Copy link
Copy Markdown
Member Author

I am slightly confused about CI - I would have expected more to break..

@Vierkantor Vierkantor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

bors r+

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Jun 5, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 5, 2026
Follow-up of #37779, where abstract `IsApply` classes were introduced. Now, we can prove a generic `sum_apply` lemma
and in following PRs this will replace specific ones in function spaces.
@mathlib-bors

mathlib-bors Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Algebra): add abstract prod_apply and FunLike.coe_prod [Merged by Bors] - feat(Algebra): add abstract prod_apply and FunLike.coe_prod Jun 5, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 5, 2026
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…prover-community#39657)

Follow-up of leanprover-community#37779, where abstract `IsApply` classes were introduced. Now, we can prove a generic `sum_apply` lemma
and in following PRs this will replace specific ones in function spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants