[Merged by Bors] - feat(Algebra): add abstract prod_apply and FunLike.coe_prod#39657
Closed
mcdoll wants to merge 7 commits into
Closed
[Merged by Bors] - feat(Algebra): add abstract prod_apply and FunLike.coe_prod#39657mcdoll wants to merge 7 commits into
prod_apply and FunLike.coe_prod#39657mcdoll wants to merge 7 commits into
Conversation
PR summary 6575e8668e
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.BigOperators.Pi | 548 | 549 | +1 (+0.18%) |
| Mathlib.Data.Matrix.PEquiv | 790 | 791 | +1 (+0.13%) |
| Mathlib.LinearAlgebra.Matrix.Polynomial | 1291 | 1292 | +1 (+0.08%) |
| Mathlib.LinearAlgebra.QuadraticForm.Dual | 1621 | 1622 | +1 (+0.06%) |
| Mathlib.Analysis.Calculus.FDeriv.Add | 1743 | 1744 | +1 (+0.06%) |
Import changes for all files
| Files | Import difference |
|---|---|
| ../mathlib-ci/scripts/pr_summary/import_trans_difference.sh all | |
| There are 3837 files with changed transitive imports taking up over 176703 characters: this is too many to display! | |
You can run this locally from your mathlib4 directory: |
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
Declarations diff
+ FunLike.coe_prod
+ prod_apply
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to strong technical debt.
No changes to weak technical debt.
Current commit 6575e8668e
Reference commit 041f76daf0
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
mcdoll
marked this pull request as ready for review
May 21, 2026 15:05
Member
Author
|
I am slightly confused about CI - I would have expected more to break.. |
Vierkantor
approved these changes
Jun 5, 2026
Vierkantor
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks!
bors r+
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jun 5, 2026
Follow-up of #37779, where abstract `IsApply` classes were introduced. Now, we can prove a generic `sum_apply` lemma and in following PRs this will replace specific ones in function spaces.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
prod_apply and FunLike.coe_prodprod_apply and FunLike.coe_prod
ReemMelamed
pushed a commit
to ReemMelamed/mathlib4
that referenced
this pull request
Jun 20, 2026
…prover-community#39657) Follow-up of leanprover-community#37779, where abstract `IsApply` classes were introduced. Now, we can prove a generic `sum_apply` lemma and in following PRs this will replace specific ones in function spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #37779, where abstract
IsApplyclasses were introduced. Now, we can prove a genericsum_applylemmaand in following PRs this will replace specific ones in function spaces.