-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: create a Basic top folder
#39703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
8935395
fa6af63
e3e76f4
c11db10
7439ff4
d37a9e6
4b81430
73344e3
e151155
2e29849
ebcdb40
da2e271
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
YaelDillies marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Basic mathematical properties and objects | ||
|
|
||
| This folder is intended to host definitions that are used throughout mathematics without necessarily | ||
| belonging to a specific area, such as the notion of a non-empty type or the complex numbers. | ||
|
|
||
| Note that results about the reals/complex numbers do not necessarily belong here. | ||
| For example, the normed group structure on them belongs in `Analysis` instead. | ||
| The order on the real numbers however belongs here because it is used to define the nonnegative real | ||
| numbers. | ||
|
|
||
| The imports are meant to stay comparatively minimal. |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Data structures | ||
|
|
||
| This folder contains results about data structures such as `List`, `Bool` or `Option`. | ||
| In an ideal world, this folder wouldn't exist as its content could reasonably be upstreamed | ||
| to either Core or Batteries. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think I agree with this sentence. I think that there is a small set of data structures which are only relevant for mathlib and hence not suitable for inclusion in core or batteries. I think the differentiation should be more about the material appearing in this folder being supporting material for making mathlib possible, but not really mathematics itself.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My opinion would be for this material to be in |
||
|
|
||
| ## TODO | ||
|
|
||
| Currently this folder contains a lot of non-data structures that should move to either `Basic`, | ||
| `Algebra` or `Order`. | ||
Uh oh!
There was an error while loading. Please reload this page.