[Merged by Bors] - chore(Data/Tree/Basic): Rename Tree to BinaryTree#39707
[Merged by Bors] - chore(Data/Tree/Basic): Rename Tree to BinaryTree#39707sorrachai wants to merge 45 commits into
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 9ab2f22441
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.Tree.Basic | 58 | 59 | +1 (+1.72%) |
| Mathlib.Data.Tree.Get | 63 | 64 | +1 (+1.59%) |
| Mathlib.Data.Tree.Traversable | 101 | 102 | +1 (+0.99%) |
Import changes for all files
| Files | Import difference |
|---|---|
3 filesMathlib.Data.Tree.Basic Mathlib.Data.Tree.Get Mathlib.Data.Tree.Traversable |
1 |
Declarations diff (regex)
+ BinaryTree.{u}
+ Tree
+ Tree.nil.{u}
+ Tree.node.{u}
+ _root_.Tree.get
+ _root_.Tree.getOrElse
+ _root_.Tree.height
+ _root_.Tree.indexOf
+ _root_.Tree.left
+ _root_.Tree.map
+ _root_.Tree.numLeaves
+ _root_.Tree.numNodes
+ _root_.Tree.right
+ _root_.Tree.traverse
+ _root_.Tree.treesOfNumNodesEq
+ _root_.Tree.unitRecOn
+ instance : Inhabited (BinaryTree α)
+ instance : LawfulTraversable BinaryTree
+ instance : Traversable BinaryTree
- Tree.{u}
- instance : Inhabited (Tree α)
- instance : LawfulTraversable Tree
- instance : Traversable Tree
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
9ab2f22).
- +65 new declarations
- −50 removed declarations
+BinaryTree
+BinaryTree.below
+BinaryTree.brecOn
+BinaryTree.brecOn.eq
+BinaryTree.brecOn.go
+BinaryTree.casesOn
+BinaryTree.coe_treesOfNumNodesEq
+BinaryTree.comp_map
+BinaryTree.comp_traverse
+BinaryTree.ctorElim
+BinaryTree.ctorElimType
+BinaryTree.ctorIdx
+BinaryTree.get
+BinaryTree.getOrElse
+BinaryTree.height
+BinaryTree.height.eq_def
+BinaryTree.height_le_numNodes
+BinaryTree.id_map
+BinaryTree.indexOf
+BinaryTree.instInhabited
+BinaryTree.instLawfulTraversable
+BinaryTree.instTraversable
+BinaryTree.left
+BinaryTree.left_node_right_eq_self
+BinaryTree.map
+BinaryTree.map.eq_def
+BinaryTree.mem_treesOfNumNodesEq
+BinaryTree.mem_treesOfNumNodesEq_numNodes
+BinaryTree.naturality
+BinaryTree.nil
+BinaryTree.nil.elim
+BinaryTree.nil.sizeOf_spec
+BinaryTree.noConfusion
+BinaryTree.noConfusionType
+BinaryTree.node
+BinaryTree.node.elim
+BinaryTree.node.inj
+BinaryTree.node.injEq
+BinaryTree.node.noConfusion
+BinaryTree.node.sizeOf_spec
+BinaryTree.numLeaves
+BinaryTree.numLeaves.eq_def
+BinaryTree.numLeaves_eq_numNodes_succ
+BinaryTree.numLeaves_pos
+BinaryTree.numNodes
+BinaryTree.numNodes.eq_def
+BinaryTree.pairwiseNode
+BinaryTree.rec
+BinaryTree.recOn
+BinaryTree.right
+BinaryTree.traverse
+BinaryTree.traverse.eq_def
+BinaryTree.traverse_eq_map_id
+BinaryTree.traverse_pure
+BinaryTree.treesOfNumNodesEq
+BinaryTree.treesOfNumNodesEq.eq_def
+BinaryTree.treesOfNumNodesEq_card_eq_catalan
+BinaryTree.treesOfNumNodesEq_succ
+BinaryTree.treesOfNumNodesEq_zero
+BinaryTree.unitRecOn
+BinaryTree.«term_△_»
-Tree.below
-Tree.brecOn
-Tree.brecOn.eq
-Tree.brecOn.go
-Tree.casesOn
-Tree.coe_treesOfNumNodesEq
-Tree.comp_map
-Tree.comp_traverse
-Tree.ctorElim
-Tree.ctorElimType
-Tree.ctorIdx
-Tree.height.eq_def
-Tree.height_le_numNodes
-Tree.id_map
-Tree.instInhabited
-Tree.instLawfulTraversable
-Tree.instTraversable
-Tree.left_node_right_eq_self
-Tree.map.eq_def
-Tree.mem_treesOfNumNodesEq
-Tree.mem_treesOfNumNodesEq_numNodes
-Tree.naturality
-Tree.nil.elim
-Tree.nil.sizeOf_spec
-Tree.noConfusion
-Tree.noConfusionType
-Tree.node.elim
-Tree.node.inj
-Tree.node.injEq
-Tree.node.noConfusion
-Tree.node.sizeOf_spec
-Tree.numLeaves.eq_def
-Tree.numLeaves_eq_numNodes_succ
-Tree.numLeaves_pos
-Tree.numNodes.eq_def
-Tree.pairwiseNode
-Tree.rec
-Tree.recOn
-Tree.traverse.eq_def
-Tree.traverse_eq_map_id
-Tree.traverse_pure
-Tree.treesOfNumNodesEq.eq_def
-Tree.treesOfNumNodesEq_card_eq_catalan
-Tree.treesOfNumNodesEq_succ
-Tree.treesOfNumNodesEq_zero
-Tree.«term_△_»
+instDecidableEqBinaryTree
+instDecidableEqBinaryTree.decEq
-instDecidableEqTree
-instDecidableEqTree.decEq
+instReprBinaryTree
+instReprBinaryTree.repr
-instReprTree
-instReprTree.reprNo changes to strong technical debt.
No changes to weak technical debt.
Current commit 9ab2f22441
Reference commit d90090f647
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Should I change anything? |
|
bors merge Thanks! |
|
👎 Rejected by label |
|
bors merge |
Rename `Tree` to `BinaryTree`. This frees up the name `Tree` to cover n-ary trees in future. We only deprecate the `def`s, and move the theorems without deprecation. Co-authored-by: Eric Wieser <efw@google.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
`Tree` was renamed to `BinaryTree` in leanprover-community#39707, but `docs/overview.yaml` still referred to the old name, failing the check-yaml post-build step. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ty#39707) Rename `Tree` to `BinaryTree`. This frees up the name `Tree` to cover n-ary trees in future. We only deprecate the `def`s, and move the theorems without deprecation. Co-authored-by: Eric Wieser <efw@google.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…ty#39707) Rename `Tree` to `BinaryTree`. This frees up the name `Tree` to cover n-ary trees in future. We only deprecate the `def`s, and move the theorems without deprecation. Co-authored-by: Eric Wieser <efw@google.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Rename
TreetoBinaryTree.This frees up the name
Treeto cover n-ary trees in future.We only deprecate the
defs, and move the theorems without deprecation.