[Merged by Bors] - feat(RingTheory/Smooth/Basic): add Generators.mvPolynomial#39708
Closed
justus-springer wants to merge 4 commits into
Closed
Conversation
PR summary 5842b13b08Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
1 task
mathlib-dependent-issues
Bot
added
the
blocked-by-other-PR
mathlib-dependent-issues
Bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
robin-carlier
left a comment
robin-carlier
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by robin-carlier. |
mathlib-triage
Bot
added
the
maintainer-merge
faenuccio
reviewed
May 26, 2026
| rw [algebraMap_self] | ||
| exact RingHomSurjective.is_surjective | ||
|
|
||
| variable (R ι) in |
Contributor
There was a problem hiding this comment.
Can you add this also to the docstring at the top of the file?
Collaborator
Author
There was a problem hiding this comment.
Added to the module docstring
Contributor
|
awaiting-author |
github-actions
Bot
added
the
awaiting-author
justus-springer
added
awaiting-CI
github-actions
Bot
removed
the
awaiting-CI
Contributor
|
Thanks bors r+ |
mathlib-triage
Bot
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 26, 2026
Define trivial `Generators` for `MvPolynomial` and use it to golf `FormallySmooth.mvPolynomial` (where they were previously defined inline). This also removes a `set_option backward.isDefEq.respectTransparency false`. - [x] depends on: #39706
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Generators.mvPolynomialGenerators.mvPolynomial
b-mehta
pushed a commit
to b-mehta/mathlib4
that referenced
this pull request
Jun 2, 2026
…ver-community#39708) Define trivial `Generators` for `MvPolynomial` and use it to golf `FormallySmooth.mvPolynomial` (where they were previously defined inline). This also removes a `set_option backward.isDefEq.respectTransparency false`. - [x] depends on: leanprover-community#39706
Bergschaf
pushed a commit
to Bergschaf/mathlib4
that referenced
this pull request
Jun 3, 2026
…ver-community#39708) Define trivial `Generators` for `MvPolynomial` and use it to golf `FormallySmooth.mvPolynomial` (where they were previously defined inline). This also removes a `set_option backward.isDefEq.respectTransparency false`. - [x] depends on: leanprover-community#39706
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define trivial
GeneratorsforMvPolynomialand use it to golfFormallySmooth.mvPolynomial(where they were previously defined inline). This also removes aset_option backward.isDefEq.respectTransparency false.mvPolynomialinstance #39706