Skip to content

feat(AlgebraicGeometry/AffineSpace): affine space is smooth#39710

Open
justus-springer wants to merge 3 commits into
leanprover-community:masterfrom
justus-springer:justus/AffineSpace_smooth
Open

feat(AlgebraicGeometry/AffineSpace): affine space is smooth#39710
justus-springer wants to merge 3 commits into
leanprover-community:masterfrom
justus-springer:justus/AffineSpace_smooth

Conversation

@justus-springer

Copy link
Copy Markdown
Collaborator

Show that affine space 𝔸(n; S) is smooth over S (or relative dimension Nat.card n) . Also remove the LocallyOfFinitePresentation instance, as it can be inferred automatically from smoothness.


Open in Gitpod

@github-actions github-actions Bot added large-import Automatically added label for PRs with a significant increase in transitive imports t-algebraic-geometry Algebraic geometry labels May 22, 2026
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

PR summary 2eecea44be

Import changes exceeding 2%

% File
+9.52% Mathlib.AlgebraicGeometry.AffineSpace

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.AlgebraicGeometry.AffineSpace 2458 2692 +234 (+9.52%)
Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.AffineSpace 234

Declarations diff

+ IsStandardSmoothOfRelativeDimension.mvPolynomial
+ IsStandardSmoothOfRelativeDimension.mvPolynomial_fin
+ dimension_mvPolynomial
+ instance [Finite n] : Smooth (𝔸(n; S) ↘ S) := (smoothOfRelativeDimension n S).smooth
+ jacobian_mvPolynomial
+ smoothOfRelativeDimension
+ smoothOfRelativeDimension_fin
+++ mvPolynomial
- instance [Finite n] : LocallyOfFinitePresentation (𝔸(n; S) ↘ S)

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 2eecea44be
Reference commit f6eb107aa5

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
    • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 22, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

This PR/issue depends on:

@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 23, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 30, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant