Skip to content

[Merged by Bors] - feat: stationary sets#39727

Closed
vihdzp wants to merge 21 commits into
leanprover-community:masterfrom
vihdzp:statminusminusminus
Closed

[Merged by Bors] - feat: stationary sets#39727
vihdzp wants to merge 21 commits into
leanprover-community:masterfrom
vihdzp:statminusminusminus

Conversation

@vihdzp

@vihdzp vihdzp commented May 22, 2026

Copy link
Copy Markdown
Collaborator

We define stationary sets as sets intersecting all club sets, and prove basic theorems about them.


Open in Gitpod

@vihdzp vihdzp added the t-set-theory Set theory label May 22, 2026
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

PR summary 69a36e5635

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ IsClub.isStationary
+ IsCofinal.nonempty
+ IsStationary
+ IsStationary.mono
+ IsStationary.nonempty
+ IsStationary.of_not_isCofinal_compl
+ IsStationary.univ
+ _root_.isClub_empty_iff
+ iInter_of_countable
+ isStationary_iUnion_iff
+ isStationary_iUnion_iff_of_cof_le_one
+ isStationary_iUnion_iff_of_countable
+ isStationary_iUnion_iff_of_orderTop
+ isStationary_sUnion_iff
+ isStationary_sUnion_iff_of_cof_le_one
+ isStationary_sUnion_iff_of_countable
+ isStationary_sUnion_iff_of_orderTop
+ isStationary_union_iff
+ isStationary_univ_iff
+ nonempty
+ not_isStationary_empty
+ not_isStationary_iff
+ not_isStationary_of_isEmpty
+ sInter_of_countable

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 69a36e5).

  • +24 new declarations
  • −0 removed declarations
+IsClub.iInter_of_countable
+IsClub.isStationary
+IsClub.nonempty
+IsClub.sInter_of_countable
+IsCofinal.nonempty
+IsStationary
+IsStationary.mono
+IsStationary.nonempty
+IsStationary.of_not_isCofinal_compl
+IsStationary.univ
+isClub_empty_iff
+isStationary_iUnion_iff
+isStationary_iUnion_iff_of_cof_le_one
+isStationary_iUnion_iff_of_countable
+isStationary_iUnion_iff_of_orderTop
+isStationary_sUnion_iff
+isStationary_sUnion_iff_of_cof_le_one
+isStationary_sUnion_iff_of_countable
+isStationary_sUnion_iff_of_orderTop
+isStationary_union_iff
+isStationary_univ_iff
+not_isStationary_empty
+not_isStationary_iff
+not_isStationary_of_isEmpty

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 69a36e5635
Reference commit 7516f8d024

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp
vihdzp requested a review from YaelDillies May 22, 2026 23:08
Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated
Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add not_isStationary_of_isEmpty as a simp lemma?

Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated
Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 24, 2026
This was referenced May 24, 2026
Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated
Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated
Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated
Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated
Comment thread Mathlib/SetTheory/Cardinal/Cofinality/Club.lean Outdated
vihdzp and others added 4 commits June 4, 2026 03:55
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
@vihdzp
vihdzp temporarily deployed to cache-upload-forks June 4, 2026 10:01 — with GitHub Actions Inactive
@vihdzp
vihdzp temporarily deployed to cache-upload-forks June 4, 2026 10:44 — with GitHub Actions Inactive

@b-mehta b-mehta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 21, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 21, 2026
We define stationary sets as sets intersecting all club sets, and prove basic theorems about them.
@mathlib-bors

mathlib-bors Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat: stationary sets [Merged by Bors] - feat: stationary sets Jun 21, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 21, 2026
bryangingechen pushed a commit to jcommelin/mathlib4 that referenced this pull request Jun 22, 2026
We define stationary sets as sets intersecting all club sets, and prove basic theorems about them.
felixpernegger pushed a commit to felixpernegger/mathlib4 that referenced this pull request Jun 22, 2026
We define stationary sets as sets intersecting all club sets, and prove basic theorems about them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants