Skip to content

feat(Nat/Digits/Lemma): add a lemma to unfold Nat.digitsAppend#39752

Closed
xroblot wants to merge 1 commit into
leanprover-community:masterfrom
xroblot:add_digitsappend_def
Closed

feat(Nat/Digits/Lemma): add a lemma to unfold Nat.digitsAppend#39752
xroblot wants to merge 1 commit into
leanprover-community:masterfrom
xroblot:add_digitsappend_def

Conversation

@xroblot

@xroblot xroblot commented May 23, 2026

Copy link
Copy Markdown
Collaborator

As suggested on Zulip


Open in Gitpod

@github-actions

Copy link
Copy Markdown

PR summary 39046b0451

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ digitsAppend_def

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label May 23, 2026
@github-actions

github-actions Bot commented May 23, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@xroblot xroblot changed the title feat(Nat/Digits/Lemma): add a lemma to unfold Nat.digitsAppend feat(Nat/Digits/Lemma): add a lemma to unfold Nat.digitsAppend May 23, 2026
@xroblot xroblot added the easy < 20s of review time. See the lifecycle page for guidelines. label May 23, 2026
@ocfnash

ocfnash commented May 25, 2026

Copy link
Copy Markdown
Contributor

Although I agree with Riccardo's [remark on Zulip](#mathlib4 > expose missing in `Mathlib.Data.Nat.Digits.Lemmas`? @ 💬), I'm not yet convinced that this is the right lemma to add here. I would regard the RHS of this lemmas as an implementation detail and I think we might do better just to have API to characterise this function.

Can you give an example of why you want this?

@ocfnash ocfnash added the awaiting-author A reviewer has asked the author a question or requested changes. label May 25, 2026
@xroblot

xroblot commented May 25, 2026

Copy link
Copy Markdown
Collaborator Author

Although I agree with Riccardo's [remark on Zulip](#mathlib4 > expose missing in Mathlib.Data.Nat.Digits.Lemmas? @ 💬), I'm not yet convinced that this is the right lemma to add here. I would regard the RHS of this lemmas as an implementation detail and I think we might do better just to have API to characterise this function.

Can you give an example of why you want this?

Yeah, I agree that unfolding this definition for some use outside of this file does not make much sense. A better solution is probably to eventually add the results and/or API that I need directly to this file. I'll close this PR.

@xroblot xroblot closed this May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. easy < 20s of review time. See the lifecycle page for guidelines. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants