Skip to content

[Merged by Bors] - chore(Algebra/Star): clean up simp lemmas about bundled star equivalences#39757

Closed
gasparattila wants to merge 9 commits into
leanprover-community:masterfrom
gasparattila:star-equiv-simp
Closed

[Merged by Bors] - chore(Algebra/Star): clean up simp lemmas about bundled star equivalences#39757
gasparattila wants to merge 9 commits into
leanprover-community:masterfrom
gasparattila:star-equiv-simp

Conversation

@gasparattila

Copy link
Copy Markdown
Contributor

This PR adds .symm lemmas for these equivalences, allowing simp to reduce applications of their inverses to applications of star.


Open in Gitpod

…valences

This PR adds `.symm` lemmas for these equivalences, allowing `simp` to reduce applications of their inverses to applications of `star`.
@github-actions

github-actions Bot commented May 23, 2026

Copy link
Copy Markdown

PR summary e648de2d58

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Equiv.Perm.symm_star
+ starL'_symm_apply
+ starL_symm_apply
+ starLinearEquiv_symm_apply
+ symm_starAddEquiv
+ symm_starL
+ symm_starL'
+ symm_starLinearEquiv
+ symm_starₗᵢ
+ toAddEquiv_starLinearEquiv
+ toEquiv_starAddEquiv
+ toLinearEquiv_starL
+ toLinearEquiv_starₗᵢ

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit e648de2d58
Reference commit 01e91cd1ce

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Algebra/Star/Basic.lean Outdated
Comment thread Mathlib/Algebra/Star/Module.lean
Comment thread Mathlib/Topology/Algebra/Module/Star.lean
Comment thread Mathlib/Topology/Algebra/Module/Star.lean Outdated
@themathqueen

Copy link
Copy Markdown
Collaborator

I think you have a merge conflict. Probably from Equiv.star (renamed to Equiv.Perm.star). Please merge master :)

Comment thread Mathlib/Algebra/Star/Basic.lean Outdated
Comment thread Mathlib/Algebra/Star/Module.lean
Comment thread Mathlib/Analysis/CStarAlgebra/Basic.lean
Comment thread Mathlib/Topology/Algebra/Module/Star.lean
@themathqueen themathqueen added awaiting-author A reviewer has asked the author a question or requested changes. t-algebra Algebra (groups, rings, fields, etc) labels Jun 2, 2026
@themathqueen themathqueen self-assigned this Jun 2, 2026
@gasparattila

Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 3, 2026
@gasparattila
gasparattila temporarily deployed to cache-upload-forks June 3, 2026 20:00 — with GitHub Actions Inactive
variable (R : Type*) {A : Type*} [CommSemiring R] [StarRing R] [AddCommMonoid A]
[StarAddMonoid A] [Module R A] [StarModule R A] [TopologicalSpace A] [ContinuousStar A]

set_option backward.defeqAttrib.useBackward true in

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default tactic for the continuity fields calls dsimp, which became much stricter recently. I plan to fix this default tactic later, so I would prefer to keep it this way for now. In fact, the real goal of this PR was to remove the manual proofs here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this comment, everything looks good thanks. Let's see what others think about this,

maintainer merge?

@gasparattila
gasparattila temporarily deployed to cache-upload-forks June 3, 2026 20:28 — with GitHub Actions Inactive
@gasparattila
gasparattila temporarily deployed to cache-upload-forks June 3, 2026 21:04 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 4, 2026
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 5, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 5, 2026
…valences (#39757)

This PR adds `.symm` lemmas for these equivalences, allowing `simp` to reduce applications of their inverses to applications of `star`.
@mathlib-bors

mathlib-bors Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Algebra/Star): clean up simp lemmas about bundled star equivalences [Merged by Bors] - chore(Algebra/Star): clean up simp lemmas about bundled star equivalences Jun 5, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 5, 2026
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…valences (leanprover-community#39757)

This PR adds `.symm` lemmas for these equivalences, allowing `simp` to reduce applications of their inverses to applications of `star`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants