[Merged by Bors] - chore(Algebra/Star): clean up simp lemmas about bundled star equivalences#39757
[Merged by Bors] - chore(Algebra/Star): clean up simp lemmas about bundled star equivalences#39757gasparattila wants to merge 9 commits into
simp lemmas about bundled star equivalences#39757Conversation
…valences This PR adds `.symm` lemmas for these equivalences, allowing `simp` to reduce applications of their inverses to applications of `star`.
PR summary e648de2d58Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
I think you have a merge conflict. Probably from |
…lib4 into star-equiv-simp
|
-awaiting-author |
| variable (R : Type*) {A : Type*} [CommSemiring R] [StarRing R] [AddCommMonoid A] | ||
| [StarAddMonoid A] [Module R A] [StarModule R A] [TopologicalSpace A] [ContinuousStar A] | ||
|
|
||
| set_option backward.defeqAttrib.useBackward true in |
There was a problem hiding this comment.
why is this needed now?
There was a problem hiding this comment.
The default tactic for the continuity fields calls dsimp, which became much stricter recently. I plan to fix this default tactic later, so I would prefer to keep it this way for now. In fact, the real goal of this PR was to remove the manual proofs here.
There was a problem hiding this comment.
Besides this comment, everything looks good thanks. Let's see what others think about this,
maintainer merge?
|
🚀 Pull request has been placed on the maintainer queue by themathqueen. |
|
Thanks! bors merge |
…valences (#39757) This PR adds `.symm` lemmas for these equivalences, allowing `simp` to reduce applications of their inverses to applications of `star`.
|
Pull request successfully merged into master. Build succeeded: |
simp lemmas about bundled star equivalencessimp lemmas about bundled star equivalences
…valences (leanprover-community#39757) This PR adds `.symm` lemmas for these equivalences, allowing `simp` to reduce applications of their inverses to applications of `star`.
This PR adds
.symmlemmas for these equivalences, allowingsimpto reduce applications of their inverses to applications ofstar.