Skip to content

[Merged by Bors] - chore(Topology/UniformSpace): rename uniformContinuous_iff to uniformContinuous_iff_le_comap#39762

Closed
plp127 wants to merge 2 commits into
leanprover-community:masterfrom
plp127:aliu/uniformContinuous
Closed

[Merged by Bors] - chore(Topology/UniformSpace): rename uniformContinuous_iff to uniformContinuous_iff_le_comap#39762
plp127 wants to merge 2 commits into
leanprover-community:masterfrom
plp127:aliu/uniformContinuous

Conversation

@plp127

@plp127 plp127 commented May 24, 2026

Copy link
Copy Markdown
Contributor

Rename uniformContinuous_iff to uniformContinuous_iff_le_comap, to match continuous_iff_le_induced, and also to have symmetry with a possible lemma uniformContinuous_iff_map_le which doesn't exist now but could be added in the future.


PS. VSCode rename thing is amazing, it tells me "this will rename 20 occurrences in 5 files" and I click ok and it just does it

Open in Gitpod

@plp127 plp127 added the t-topology Topological spaces, uniform spaces, metric spaces, filters label May 24, 2026
@github-actions

github-actions Bot commented May 24, 2026

Copy link
Copy Markdown

PR summary e994632936

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ uniformContinuous_iff_le_comap

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@themathqueen

Copy link
Copy Markdown
Collaborator

PS. VSCode rename thing is amazing, it tells me "this will rename 20 occurrences in 5 files" and I click ok and it just does it

Woah... do you have an extension installed for that??

@plp127

plp127 commented May 24, 2026

Copy link
Copy Markdown
Contributor Author

PS. VSCode rename thing is amazing, it tells me "this will rename 20 occurrences in 5 files" and I click ok and it just does it

Woah... do you have an extension installed for that??

just the normal Lean extension I think

@ADedecker

Copy link
Copy Markdown
Member

There's no way this feature has been here for so long and I've never noticed it... I was complaining about having no such features just two weeks ago...

@ADedecker

Copy link
Copy Markdown
Member

Anyways, thanks for the PR and teaching me about a feature !

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 27, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 27, 2026
…ormContinuous_iff_le_comap` (#39762)

Rename `uniformContinuous_iff` to `uniformContinuous_iff_le_comap`, to match `continuous_iff_le_induced`, and also to have symmetry with a possible lemma `uniformContinuous_iff_map_le` which doesn't exist now but could be added in the future.
@mathlib-bors

mathlib-bors Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Topology/UniformSpace): rename uniformContinuous_iff to uniformContinuous_iff_le_comap [Merged by Bors] - chore(Topology/UniformSpace): rename uniformContinuous_iff to uniformContinuous_iff_le_comap May 27, 2026
@mathlib-bors mathlib-bors Bot closed this May 27, 2026
@plp127
plp127 deleted the aliu/uniformContinuous branch May 27, 2026 18:50
grunweg pushed a commit to grunweg/mathlib4 that referenced this pull request May 30, 2026
…ormContinuous_iff_le_comap` (leanprover-community#39762)

Rename `uniformContinuous_iff` to `uniformContinuous_iff_le_comap`, to match `continuous_iff_le_induced`, and also to have symmetry with a possible lemma `uniformContinuous_iff_map_le` which doesn't exist now but could be added in the future.
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
…ormContinuous_iff_le_comap` (leanprover-community#39762)

Rename `uniformContinuous_iff` to `uniformContinuous_iff_le_comap`, to match `continuous_iff_le_induced`, and also to have symmetry with a possible lemma `uniformContinuous_iff_map_le` which doesn't exist now but could be added in the future.
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…ormContinuous_iff_le_comap` (leanprover-community#39762)

Rename `uniformContinuous_iff` to `uniformContinuous_iff_le_comap`, to match `continuous_iff_le_induced`, and also to have symmetry with a possible lemma `uniformContinuous_iff_map_le` which doesn't exist now but could be added in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants