Skip to content

feat(Algebra/GroupWithZero/Divisibility): add mul_dvd_left_iff_isUnit#39763

Open
NoahW314 wants to merge 3 commits into
leanprover-community:masterfrom
NoahW314:mul_dvd_isUnit
Open

feat(Algebra/GroupWithZero/Divisibility): add mul_dvd_left_iff_isUnit#39763
NoahW314 wants to merge 3 commits into
leanprover-community:masterfrom
NoahW314:mul_dvd_isUnit

Conversation

@NoahW314

Copy link
Copy Markdown
Contributor

Open in Gitpod

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 24, 2026
@github-actions

github-actions Bot commented May 24, 2026

Copy link
Copy Markdown

PR summary 3ce69d5c6f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ mul_dvd_left_iff_isUnit
+ mul_dvd_right_iff_isUnit

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 3ce69d5).

  • +2 new declarations
  • −0 removed declarations
+mul_dvd_left_iff_isUnit
+mul_dvd_right_iff_isUnit

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 3ce69d5c6f
Reference commit 843d7890de

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants