[Merged by Bors] - doc(RingTheory): fix local ring doc comment#39765
Closed
vlad902 wants to merge 1 commit into
Closed
[Merged by Bors] - doc(RingTheory): fix local ring doc comment#39765vlad902 wants to merge 1 commit into
vlad902 wants to merge 1 commit into
Conversation
The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.
PR summary 8af42bb664Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
|
Thanks! bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jun 19, 2026
The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
ReemMelamed
pushed a commit
to ReemMelamed/mathlib4
that referenced
this pull request
Jun 20, 2026
The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.
bryangingechen
pushed a commit
to jcommelin/mathlib4
that referenced
this pull request
Jun 22, 2026
The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.