Skip to content

[Merged by Bors] - doc(RingTheory): fix local ring doc comment#39765

Closed
vlad902 wants to merge 1 commit into
leanprover-community:masterfrom
vlad902:doc-localring
Closed

[Merged by Bors] - doc(RingTheory): fix local ring doc comment#39765
vlad902 wants to merge 1 commit into
leanprover-community:masterfrom
vlad902:doc-localring

Conversation

@vlad902

@vlad902 vlad902 commented May 24, 2026

Copy link
Copy Markdown
Collaborator

The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.


Open in Gitpod

The predicate for local rings was updated to the current definition on
non-commutative semirings back in mathlib3, but the outdated comment
stating that local rings are commutative rings with a unique maximal
ideal has not been updated since.
@github-actions

Copy link
Copy Markdown

PR summary 8af42bb664

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the t-ring-theory Ring theory label May 24, 2026
@vlad902 vlad902 added the easy < 20s of review time. See the lifecycle page for guidelines. label Jun 18, 2026
@faenuccio

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Jun 19, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.
@mathlib-bors

mathlib-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title doc(RingTheory): fix local ring doc comment [Merged by Bors] - doc(RingTheory): fix local ring doc comment Jun 19, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 19, 2026
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.
bryangingechen pushed a commit to jcommelin/mathlib4 that referenced this pull request Jun 22, 2026
The predicate for local rings was updated to the current definition on non-commutative semirings back in mathlib3, but the outdated comment stating that local rings are commutative rings with a unique maximal ideal has not been updated since.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants