Skip to content

chore(Topology): refactor proofs where grind? fails#39769

Open
chenson2018 wants to merge 1 commit into
leanprover-community:masterfrom
chenson2018:topology-verify-grind-only
Open

chore(Topology): refactor proofs where grind? fails#39769
chenson2018 wants to merge 1 commit into
leanprover-community:masterfrom
chenson2018:topology-verify-grind-only

Conversation

@chenson2018

Copy link
Copy Markdown
Contributor

These are sources of technical debt as now reported in the weekly linting report. The idea is that a successful grind proof can fail to report the theorems it used via grind?, which means that if these proofs break across toolchains that it becomes significantly harder to repair.

Most of these are fixed by squeezing the call to grind and unsetting linter.tacticAnalysis.verifyGrindOnly so they no longer appear in the weekly report. Unfortunately, this can't be on by default for performance reasons, but I highly encourage using this linter when adding any grind proofs.


Open in Gitpod

@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label May 24, 2026
@github-actions

Copy link
Copy Markdown

PR summary b9d8d954f7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@grunweg grunweg added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label May 25, 2026
@chenson2018 chenson2018 changed the title chore(Topology): reactor proofs where grind? fails chore(Topology): refactor proofs where grind? fails May 25, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-topology Topological spaces, uniform spaces, metric spaces, filters tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants