Skip to content

perf: add some fast_instance%#39773

Closed
kbuzzard wants to merge 1 commit into
leanprover-community:masterfrom
kbuzzard:kbuzzard-more-fast-instance
Closed

perf: add some fast_instance%#39773
kbuzzard wants to merge 1 commit into
leanprover-community:masterfrom
kbuzzard:kbuzzard-more-fast-instance

Conversation

@kbuzzard

@kbuzzard kbuzzard commented May 24, 2026

Copy link
Copy Markdown
Member

This PR adds some fast_instance%s, which tidies up some terms.

See #mathlib4 > fast_instance% plans for explicit descriptions of what every change in this PR actually does to the terms in question.


Open in Gitpod

@kbuzzard

Copy link
Copy Markdown
Member Author

!radar

@leanprover-radar

leanprover-radar commented May 24, 2026

Copy link
Copy Markdown

Benchmark results for dbbfd1a against 88330eb are in. No significant results found. @kbuzzard

  • build//instructions: -34.2G (-0.02%)

No significant changes detected.

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 24, 2026
@github-actions

Copy link
Copy Markdown

PR summary dbbfd1a2fe

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Group.Pi.Basic 107 108 +1 (+0.93%)
Mathlib.Algebra.Group.TypeTags.Basic 135 136 +1 (+0.74%)
Import changes for all files
Files Import difference
52 files Mathlib.Algebra.Divisibility.Prod Mathlib.Algebra.EuclideanDomain.Int Mathlib.Algebra.FreeMonoid.Count Mathlib.Algebra.Group.Action.Basic Mathlib.Algebra.Group.Action.End Mathlib.Algebra.Group.Action.Hom Mathlib.Algebra.Group.Action.Pretransitive Mathlib.Algebra.Group.Action.Prod Mathlib.Algebra.Group.Action.TypeTags Mathlib.Algebra.Group.Conj Mathlib.Algebra.Group.End Mathlib.Algebra.Group.Equiv.TypeTags Mathlib.Algebra.Group.Even Mathlib.Algebra.Group.Int.Even Mathlib.Algebra.Group.Int.TypeTags Mathlib.Algebra.Group.Irreducible.Lemmas Mathlib.Algebra.Group.Nat.Even Mathlib.Algebra.Group.Nat.Hom Mathlib.Algebra.Group.Nat.TypeTags Mathlib.Algebra.Group.Pi.Basic Mathlib.Algebra.Group.Pi.Units Mathlib.Algebra.Group.TypeTags.Basic Mathlib.Algebra.Group.TypeTags.Hom Mathlib.Algebra.GroupWithZero.Action.Basic Mathlib.Algebra.GroupWithZero.Action.End Mathlib.Algebra.GroupWithZero.Action.Prod Mathlib.Algebra.GroupWithZero.Associated Mathlib.Algebra.GroupWithZero.Conj Mathlib.Algebra.GroupWithZero.Pi Mathlib.Algebra.GroupWithZero.ProdHom Mathlib.Algebra.GroupWithZero.Prod Mathlib.Algebra.GroupWithZero.WithZero Mathlib.Algebra.Module.Prod Mathlib.Algebra.Order.Group.Abs Mathlib.Algebra.Order.Group.MinMax Mathlib.Algebra.Order.Group.PosPart Mathlib.Algebra.Order.Group.Unbundled.Abs Mathlib.Algebra.Order.Group.Unbundled.Int Mathlib.Algebra.Order.Hom.Basic Mathlib.Algebra.Order.Hom.TypeTags Mathlib.Algebra.Order.Monoid.Associated Mathlib.Algebra.Order.Monoid.TypeTags Mathlib.Algebra.Order.Monoid.Unbundled.TypeTags Mathlib.Algebra.Order.Ring.Unbundled.Rat Mathlib.Algebra.Order.Sub.Basic Mathlib.Algebra.Prime.Lemmas Mathlib.Algebra.Ring.WithZero Mathlib.Control.Fix Mathlib.Data.FunLike.Group Mathlib.Data.List.Prime Mathlib.Data.Matrix.DMatrix Mathlib.Data.Nat.Upto
1

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 30, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@kbuzzard kbuzzard closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants