perf: add some fast_instance%#39773
Closed
kbuzzard wants to merge 1 commit into
Closed
Conversation
Member
Author
|
!radar |
|
Benchmark results for dbbfd1a against 88330eb are in. No significant results found. @kbuzzard
No significant changes detected. |
PR summary dbbfd1a2fe
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Group.Pi.Basic | 107 | 108 | +1 (+0.93%) |
| Mathlib.Algebra.Group.TypeTags.Basic | 135 | 136 | +1 (+0.74%) |
Import changes for all files
| Files | Import difference |
|---|---|
52 filesMathlib.Algebra.Divisibility.Prod Mathlib.Algebra.EuclideanDomain.Int Mathlib.Algebra.FreeMonoid.Count Mathlib.Algebra.Group.Action.Basic Mathlib.Algebra.Group.Action.End Mathlib.Algebra.Group.Action.Hom Mathlib.Algebra.Group.Action.Pretransitive Mathlib.Algebra.Group.Action.Prod Mathlib.Algebra.Group.Action.TypeTags Mathlib.Algebra.Group.Conj Mathlib.Algebra.Group.End Mathlib.Algebra.Group.Equiv.TypeTags Mathlib.Algebra.Group.Even Mathlib.Algebra.Group.Int.Even Mathlib.Algebra.Group.Int.TypeTags Mathlib.Algebra.Group.Irreducible.Lemmas Mathlib.Algebra.Group.Nat.Even Mathlib.Algebra.Group.Nat.Hom Mathlib.Algebra.Group.Nat.TypeTags Mathlib.Algebra.Group.Pi.Basic Mathlib.Algebra.Group.Pi.Units Mathlib.Algebra.Group.TypeTags.Basic Mathlib.Algebra.Group.TypeTags.Hom Mathlib.Algebra.GroupWithZero.Action.Basic Mathlib.Algebra.GroupWithZero.Action.End Mathlib.Algebra.GroupWithZero.Action.Prod Mathlib.Algebra.GroupWithZero.Associated Mathlib.Algebra.GroupWithZero.Conj Mathlib.Algebra.GroupWithZero.Pi Mathlib.Algebra.GroupWithZero.ProdHom Mathlib.Algebra.GroupWithZero.Prod Mathlib.Algebra.GroupWithZero.WithZero Mathlib.Algebra.Module.Prod Mathlib.Algebra.Order.Group.Abs Mathlib.Algebra.Order.Group.MinMax Mathlib.Algebra.Order.Group.PosPart Mathlib.Algebra.Order.Group.Unbundled.Abs Mathlib.Algebra.Order.Group.Unbundled.Int Mathlib.Algebra.Order.Hom.Basic Mathlib.Algebra.Order.Hom.TypeTags Mathlib.Algebra.Order.Monoid.Associated Mathlib.Algebra.Order.Monoid.TypeTags Mathlib.Algebra.Order.Monoid.Unbundled.TypeTags Mathlib.Algebra.Order.Ring.Unbundled.Rat Mathlib.Algebra.Order.Sub.Basic Mathlib.Algebra.Prime.Lemmas Mathlib.Algebra.Ring.WithZero Mathlib.Control.Fix Mathlib.Data.FunLike.Group Mathlib.Data.List.Prime Mathlib.Data.Matrix.DMatrix Mathlib.Data.Nat.Upto |
1 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to strong technical debt.
No changes to weak technical debt.
|
This pull request has conflicts, please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some
fast_instance%s, which tidies up some terms.See #mathlib4 > fast_instance% plans for explicit descriptions of what every change in this PR actually does to the terms in question.