feat(Order/Interval/Finset): Set.ncard lemmas for LocallyFiniteOrder#39783
Open
SnirBroshi wants to merge 2 commits into
Open
feat(Order/Interval/Finset): Set.ncard lemmas for LocallyFiniteOrder#39783SnirBroshi wants to merge 2 commits into
Set.ncard lemmas for LocallyFiniteOrder#39783SnirBroshi wants to merge 2 commits into
Conversation
PR summary 1e033e8e22Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #39414 which untagged
Fintype.card_I??as@[simp].Adds
Cardinal.mk/Set.encard/Set.ncardlemmas for the 8 interval setsSet.I??(= 24 lemmas),that convert them to
Finset.cardover the correspondingFinset.I??from aLocallyFiniteOrderinstance.simp? I think it's a bit strange since theLocallyFiniteOrderinstance could have crazy definitions for the finset intervals which aren't "simpler", though the instances we currently have are simple.