Skip to content

[Merged by Bors] - refactor(RingTheory/HopfAlgebra): ofConvInverse constructor#39785

Closed
hawkrobe wants to merge 22 commits into
leanprover-community:masterfrom
hawkrobe:hopfalgebra-ofalghom-general
Closed

[Merged by Bors] - refactor(RingTheory/HopfAlgebra): ofConvInverse constructor#39785
hawkrobe wants to merge 22 commits into
leanprover-community:masterfrom
hawkrobe:hopfalgebra-ofalghom-general

Conversation

@hawkrobe

@hawkrobe hawkrobe commented May 24, 2026

Copy link
Copy Markdown
Contributor

The antipode of a Hopf algebra is generally the two-sided inverse of the identity in the convolution algebra End(A). When A is commutative, algebra homs are closed under convolution and this lifts to AlgHom equality. See this comment on #31898.


Sadly the AlgHom-equality formulation is unavailable in the noncommutative case.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label May 24, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the t-ring-theory Ring theory label May 24, 2026
@github-actions

github-actions Bot commented May 24, 2026

Copy link
Copy Markdown

PR summary bd33e0a4c9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ofAlgHom
+ ofConvInverse
- HopfAlgebra.ofAlgHom

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit bd33e0a4c9
Reference commit 23bafd5167

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@hawkrobe
hawkrobe force-pushed the hopfalgebra-ofalghom-general branch from 07859a8 to 59f7aee Compare May 24, 2026 22:55
@hawkrobe

Copy link
Copy Markdown
Contributor Author

@YaelDillies ready for a review when you have the time.

Comment thread Mathlib/RingTheory/HopfAlgebra/Basic.lean Outdated
@YaelDillies YaelDillies self-assigned this May 25, 2026

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@YaelDillies YaelDillies removed their assignment May 25, 2026
@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 25, 2026
@faenuccio

Copy link
Copy Markdown
Contributor

@hawkrobe You've got a missing doc string causing CI to fail. Can you please fix this?

@hawkrobe

hawkrobe commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@faenuccio fixed, sorry about that!

Comment thread Mathlib/RingTheory/HopfAlgebra/Basic.lean Outdated
Comment thread Mathlib/RingTheory/HopfAlgebra/Basic.lean Outdated
noncomputable abbrev ofAlgHom [CommSemiring R] [CommSemiring A] [Bialgebra R A]
(antipode : A →ₐ[R] A)
(mul_antipode_rTensor_comul :
((Algebra.TensorProduct.lift antipode (.id R A) fun _ ↦ .all _).comp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the use of anonymous dot notation a bit hard to parse in this definition where it appears as third/fourth variable. Can you replace .all with Commute.all?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is your personal preference, Filippo. I don't think it's worth mentioning on other people's PRs.

Anonymous dot notation was created precisely for the purpose of being short. Lean code isn't designed to be readable without the infoview.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaelDillies, remember that reviewers are free to express and argue their personal preference when the style guide is ambiguous, and I would encourage you to avoid dismissing such comments on the basis of them being preference. Short discussions of conflicting personal preference should not hold up PRs, but the discussion is still worth briefly having in case it leads to clarification of the style guide.

Having said that, I do think using .all is fine here, especially as this is a proof term and not data where perceived ambiguity could even matter.

@YaelDillies YaelDillies added awaiting-author A reviewer has asked the author a question or requested changes. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 1, 2026
@YaelDillies YaelDillies self-assigned this Jun 1, 2026
@hawkrobe

hawkrobe commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

I fixed the names (and everything else raised in review)!

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 1, 2026
Comment thread Mathlib/RingTheory/HopfAlgebra/Basic.lean
@hawkrobe

hawkrobe commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

leanprover/lean4#13636 changed simpa behavior and broke the build. i kept the old behavior with using! but I'm not sure whether that's discouraged?

@grunweg

grunweg commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

I think using using! for now is fine.

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 2, 2026
@YaelDillies YaelDillies removed their assignment Jun 2, 2026
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request Jun 3, 2026
The antipode of a Hopf algebra is [generally](https://arxiv.org/pdf/1409.8356) the two-sided inverse of the identity in the convolution algebra `End(A)`. When `A` is commutative, algebra homs are closed under convolution and this lifts to AlgHom equality. See [this comment](#31898 (comment)) on #31898.
@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 3, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(RingTheory/HopfAlgebra): ofConvInverse constructor [Merged by Bors] - refactor(RingTheory/HopfAlgebra): ofConvInverse constructor Jun 3, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 3, 2026
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…over-community#39785)

The antipode of a Hopf algebra is [generally](https://arxiv.org/pdf/1409.8356) the two-sided inverse of the identity in the convolution algebra `End(A)`. When `A` is commutative, algebra homs are closed under convolution and this lifts to AlgHom equality. See [this comment](leanprover-community#31898 (comment)) on leanprover-community#31898.
@hawkrobe
hawkrobe deleted the hopfalgebra-ofalghom-general branch June 7, 2026 21:20
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…over-community#39785)

The antipode of a Hopf algebra is [generally](https://arxiv.org/pdf/1409.8356) the two-sided inverse of the identity in the convolution algebra `End(A)`. When `A` is commutative, algebra homs are closed under convolution and this lifts to AlgHom equality. See [this comment](leanprover-community#31898 (comment)) on leanprover-community#31898.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants