[Merged by Bors] - refactor(RingTheory/HopfAlgebra): ofConvInverse constructor#39785
[Merged by Bors] - refactor(RingTheory/HopfAlgebra): ofConvInverse constructor#39785hawkrobe wants to merge 22 commits into
ofConvInverse constructor#39785Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary bd33e0a4c9Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
3c356d7 to
07859a8
Compare
07859a8 to
59f7aee
Compare
|
@YaelDillies ready for a review when you have the time. |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
@hawkrobe You've got a missing doc string causing CI to fail. Can you please fix this? |
|
@faenuccio fixed, sorry about that! |
| noncomputable abbrev ofAlgHom [CommSemiring R] [CommSemiring A] [Bialgebra R A] | ||
| (antipode : A →ₐ[R] A) | ||
| (mul_antipode_rTensor_comul : | ||
| ((Algebra.TensorProduct.lift antipode (.id R A) fun _ ↦ .all _).comp |
There was a problem hiding this comment.
I find the use of anonymous dot notation a bit hard to parse in this definition where it appears as third/fourth variable. Can you replace .all with Commute.all?
There was a problem hiding this comment.
This is your personal preference, Filippo. I don't think it's worth mentioning on other people's PRs.
Anonymous dot notation was created precisely for the purpose of being short. Lean code isn't designed to be readable without the infoview.
There was a problem hiding this comment.
@YaelDillies, remember that reviewers are free to express and argue their personal preference when the style guide is ambiguous, and I would encourage you to avoid dismissing such comments on the basis of them being preference. Short discussions of conflicting personal preference should not hold up PRs, but the discussion is still worth briefly having in case it leads to clarification of the style guide.
Having said that, I do think using .all is fine here, especially as this is a proof term and not data where perceived ambiguity could even matter.
|
I fixed the names (and everything else raised in review)! -awaiting-author |
|
leanprover/lean4#13636 changed |
|
I think using |
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
Thanks! bors merge |
The antipode of a Hopf algebra is [generally](https://arxiv.org/pdf/1409.8356) the two-sided inverse of the identity in the convolution algebra `End(A)`. When `A` is commutative, algebra homs are closed under convolution and this lifts to AlgHom equality. See [this comment](#31898 (comment)) on #31898.
|
Pull request successfully merged into master. Build succeeded:
|
ofConvInverse constructorofConvInverse constructor
…over-community#39785) The antipode of a Hopf algebra is [generally](https://arxiv.org/pdf/1409.8356) the two-sided inverse of the identity in the convolution algebra `End(A)`. When `A` is commutative, algebra homs are closed under convolution and this lifts to AlgHom equality. See [this comment](leanprover-community#31898 (comment)) on leanprover-community#31898.
…over-community#39785) The antipode of a Hopf algebra is [generally](https://arxiv.org/pdf/1409.8356) the two-sided inverse of the identity in the convolution algebra `End(A)`. When `A` is commutative, algebra homs are closed under convolution and this lifts to AlgHom equality. See [this comment](leanprover-community#31898 (comment)) on leanprover-community#31898.
The antipode of a Hopf algebra is generally the two-sided inverse of the identity in the convolution algebra
End(A). WhenAis commutative, algebra homs are closed under convolution and this lifts to AlgHom equality. See this comment on #31898.Sadly the AlgHom-equality formulation is unavailable in the noncommutative case.