Skip to content

[Merged by Bors] - chore: deprecate Ordinal.IsAcc and Ordinal.IsClosedBelow#39792

Closed
vihdzp wants to merge 10 commits into
leanprover-community:masterfrom
vihdzp:easypick
Closed

[Merged by Bors] - chore: deprecate Ordinal.IsAcc and Ordinal.IsClosedBelow#39792
vihdzp wants to merge 10 commits into
leanprover-community:masterfrom
vihdzp:easypick

Conversation

@vihdzp

@vihdzp vihdzp commented May 24, 2026

Copy link
Copy Markdown
Collaborator

These predicates were introduced in #16710 as preliminaries for a development of club sets. Those have since been defined without them, so we deprecate them, and generalize the results on them to the setting of successor orders.


Open in Gitpod

@github-actions github-actions Bot added the t-set-theory Set theory label May 24, 2026
@github-actions

github-actions Bot commented May 24, 2026

Copy link
Copy Markdown

PR summary 56f7707ce0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.AccPt.isSuccLimit
+ _root_.AccPt.not_isMin
+ accPt_principal
+ nhds_bot
+ nhds_of_isMin

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 56f7707ce0
Reference commit 0531bb79fe

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp vihdzp added the easy < 20s of review time. See the lifecycle page for guidelines. label May 24, 2026
@vihdzp
vihdzp marked this pull request as draft May 24, 2026 21:46
@mathlib-bors

mathlib-bors Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@vihdzp vihdzp changed the title chore: deprecate IsAcc.monoAccPt.mono chore: deprecate Ordinal.IsAcc and Ordinal.IsClosedBelow May 24, 2026
@vihdzp
vihdzp marked this pull request as ready for review May 24, 2026 21:53
@vihdzp vihdzp removed the easy < 20s of review time. See the lifecycle page for guidelines. label May 24, 2026
@vihdzp
vihdzp requested a review from YaelDillies June 1, 2026 23:14

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

Comment thread Mathlib/Topology/Order/SuccPred.lean Outdated
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 2, 2026
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors d+

@mathlib-triage mathlib-triage Bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 3, 2026
@vihdzp

vihdzp commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Jun 3, 2026
These predicates were introduced in #16710 as preliminaries for a development of club sets. Those have [since been defined](https://leanprover-community.github.io/mathlib4_docs/Mathlib/SetTheory/Cardinal/Cofinality/Club.html#IsClub) without them, so we deprecate them, and generalize the results on them to the setting of successor orders.
@mathlib-bors

mathlib-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: deprecate Ordinal.IsAcc and Ordinal.IsClosedBelow [Merged by Bors] - chore: deprecate Ordinal.IsAcc and Ordinal.IsClosedBelow Jun 3, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 3, 2026
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…ver-community#39792)

These predicates were introduced in leanprover-community#16710 as preliminaries for a development of club sets. Those have [since been defined](https://leanprover-community.github.io/mathlib4_docs/Mathlib/SetTheory/Cardinal/Cofinality/Club.html#IsClub) without them, so we deprecate them, and generalize the results on them to the setting of successor orders.
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…ver-community#39792)

These predicates were introduced in leanprover-community#16710 as preliminaries for a development of club sets. Those have [since been defined](https://leanprover-community.github.io/mathlib4_docs/Mathlib/SetTheory/Cardinal/Cofinality/Club.html#IsClub) without them, so we deprecate them, and generalize the results on them to the setting of successor orders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants