chore(Data): refactor proofs where grind? fails#39808
Conversation
PR summary ff06817091Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
grind? failsgrind? fails
|
@kim-em, I recall that this linter was intended to generate bug reports for the Lean developers, not for fixing in Mathlib. Is that still true or is |
According to the latest weekly linting, there are 66 proofs in Mathlib that still have this problem. So the situation has improved (I recall it being about double this when I added it to weekly linting) but still exists.
This seems to be the position expressed by #40023 (comment). I understand the reasoning, but personally am not very satisfied with leaving these proofs in a state where they essentially need to be reproven by hand if there are any breaking changes in I had opened this thread to discuss, but received no response. |
These are sources of technical debt as now reported in the weekly linting report. The idea is that a successful
grindproof can fail to report the theorems it used viagrind?, which means that if these proofs break across toolchains that it becomes significantly harder to repair.Most of these are fixed by squeezing the call to
grindand unsettinglinter.tacticAnalysis.verifyGrindOnlyso they no longer appear in the weekly report. Unfortunately, this can't be on by default for performance reasons, but I highly encourage using this linter when adding anygrindproofs.