Skip to content

[Merged by Bors] - chore(OpenPartialHomeomorph): add missing deprecation#39968

Closed
scholzhannah wants to merge 11 commits into
leanprover-community:masterfrom
scholzhannah:scholzhannah/deprecation
Closed

[Merged by Bors] - chore(OpenPartialHomeomorph): add missing deprecation#39968
scholzhannah wants to merge 11 commits into
leanprover-community:masterfrom
scholzhannah:scholzhannah/deprecation

Conversation

@scholzhannah

@scholzhannah scholzhannah commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Add deprecation that I forgot in #39565.


Open in Gitpod

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown

PR summary 4b7374de7d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ symm_mapsTo

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@scholzhannah
scholzhannah marked this pull request as ready for review May 28, 2026 11:39
@scholzhannah scholzhannah changed the title chore: add missing deprecation chore (OpenPartialHomeomorph): add missing deprecation May 28, 2026
@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@scholzhannah scholzhannah changed the title chore (OpenPartialHomeomorph): add missing deprecation chore(OpenPartialHomeomorph): add missing deprecation May 28, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 28, 2026
@grunweg

grunweg commented May 28, 2026

Copy link
Copy Markdown
Contributor

Thanks! Feel free to merge once the dependency has been merged.
bors d+

@mathlib-bors

mathlib-bors Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

✌️ scholzhannah can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label May 28, 2026
@scholzhannah

Copy link
Copy Markdown
Collaborator Author

bors r+

@mathlib-bors

mathlib-bors Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

👎 Rejected by label

@scholzhannah scholzhannah removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 28, 2026
@scholzhannah

Copy link
Copy Markdown
Collaborator Author

bors r+

@themathqueen

Copy link
Copy Markdown
Collaborator

I think you need to merge master

@mathlib-bors

mathlib-bors Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Canceled.

Address comments or fix if necessary, and then someone with permission can run bors r+.

@themathqueen

Copy link
Copy Markdown
Collaborator

I merged master for you. You need to resend to bors :)

@grunweg

grunweg commented May 28, 2026

Copy link
Copy Markdown
Contributor

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 28, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

This PR/issue depends on:

mathlib-bors Bot pushed a commit that referenced this pull request May 28, 2026
Add deprecation that I forgot in #39565.

Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
@mathlib-bors

mathlib-bors Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(OpenPartialHomeomorph): add missing deprecation [Merged by Bors] - chore(OpenPartialHomeomorph): add missing deprecation May 28, 2026
@mathlib-bors mathlib-bors Bot closed this May 28, 2026
grunweg pushed a commit to grunweg/mathlib4 that referenced this pull request May 30, 2026
…munity#39968)

Add deprecation that I forgot in leanprover-community#39565.

Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
b-mehta pushed a commit to b-mehta/mathlib4 that referenced this pull request Jun 2, 2026
…munity#39968)

Add deprecation that I forgot in leanprover-community#39565.

Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
…munity#39968)

Add deprecation that I forgot in leanprover-community#39565.

Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants