Skip to content

chore(AlgebraicTopology): refactor proofs where grind? fails#40023

Open
chenson2018 wants to merge 2 commits into
leanprover-community:masterfrom
chenson2018:AlgebraicTopology-verify-grind-only
Open

chore(AlgebraicTopology): refactor proofs where grind? fails#40023
chenson2018 wants to merge 2 commits into
leanprover-community:masterfrom
chenson2018:AlgebraicTopology-verify-grind-only

Conversation

@chenson2018

Copy link
Copy Markdown
Contributor

These are sources of technical debt as now reported in the weekly linting report. The idea is that a successful grind proof can fail to report the theorems it used via grind?, which means that if these proofs break across toolchains that it becomes significantly harder to repair.


Open in Gitpod

@github-actions github-actions Bot added the t-algebraic-topology Algebraic topology label May 29, 2026
@github-actions

Copy link
Copy Markdown

PR summary 7cf290f932

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@joelriou

joelriou commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

While we believe that the linter verifyGrindOnly is useful at identifying bugs in the grind tactic, this PR (and #40022, #39769, #39808) only removes the symptoms rather than fixing the real issue which is a bug in the grind tactic in Lean core.

@joelriou joelriou added the will-close-soon Unless something changes, we will close this PR soon label Jun 9, 2026
@grunweg

grunweg commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

It would be extremely valuable to have some of these as minimized bug reports to Lean core, so the underlying issue (perhaps a grind bug) can be fixed. We appreciate this is much more work than this PR --- but if you would like to help move this forward, that would be a very helpful next step. Probably Kim's lean-minimize tool can help here.

@chenson2018

Copy link
Copy Markdown
Contributor Author

@joelriou @grunweg Thanks for the feedback. This makes sense, but still seems less than ideal in the short term from the Mathlib perspective. I opened a Zulip thread to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebraic-topology Algebraic topology will-close-soon Unless something changes, we will close this PR soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants