chore(AlgebraicTopology): refactor proofs where grind? fails#40023
Open
chenson2018 wants to merge 2 commits into
Open
chore(AlgebraicTopology): refactor proofs where grind? fails#40023chenson2018 wants to merge 2 commits into
grind? fails#40023chenson2018 wants to merge 2 commits into
Conversation
PR summary 7cf290f932Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
Contributor
|
It would be extremely valuable to have some of these as minimized bug reports to Lean core, so the underlying issue (perhaps a grind bug) can be fixed. We appreciate this is much more work than this PR --- but if you would like to help move this forward, that would be a very helpful next step. Probably Kim's lean-minimize tool can help here. |
Contributor
Author
|
@joelriou @grunweg Thanks for the feedback. This makes sense, but still seems less than ideal in the short term from the Mathlib perspective. I opened a Zulip thread to discuss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are sources of technical debt as now reported in the weekly linting report. The idea is that a successful grind proof can fail to report the theorems it used via grind?, which means that if these proofs break across toolchains that it becomes significantly harder to repair.