Skip to content

[Merged by Bors] - chore(CI): fix merge conflict resolution for nightly-testing#40257

Closed
Garmelon wants to merge 1 commit into
leanprover-community:masterfrom
Garmelon:fix-nightly-conflict-resolution
Closed

[Merged by Bors] - chore(CI): fix merge conflict resolution for nightly-testing#40257
Garmelon wants to merge 1 commit into
leanprover-community:masterfrom
Garmelon:fix-nightly-conflict-resolution

Conversation

@Garmelon

@Garmelon Garmelon commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Resolving merge conflicts in favor of nightly-testing when merging master may be convenient for nightly maintainers, but it can lead to changes made on master accidentally being dropped again later in the bump PR. For an example case, see #40189 (see #PR reviews > #39443 `nonempty_preimage_iff` @ 💬 for an explanation of what happened).

Resolving conflicts in favor of master means that nightly-testing will rather break than silently undoing changes made on master.

@Garmelon
Garmelon requested a review from kim-em June 5, 2026 12:33
@Garmelon Garmelon added the CI Modifies the continuous integration setup or other automation label Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

PR summary 4eff6a086e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 4eff6a086e
Reference commit 034a5a7a3b

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

⚠️ Workflow documentation reminder

This PR modifies files under .github/workflows/.
Please update docs/workflows.md if the workflow inventory, triggers, or behavior changed.

Modified workflow files:

  • .github/workflows/nightly_merge_master.yml

@kim-em

kim-em commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request Jun 15, 2026
Resolving merge conflicts in favor of `nightly-testing` when merging `master` may be convenient for nightly maintainers, but it can lead to changes made on `master` accidentally being dropped again later in the bump PR. For an example case, see #40189 (see [#PR reviews > #39443 &#96;nonempty_preimage_iff&#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339443.20.60nonempty_preimage_iff.60/near/599885755) for an explanation of what happened).

Resolving conflicts in favor of `master` means that `nightly-testing` will rather break than silently undoing changes made on `master`.

Co-authored-by: Joscha <joscha@plugh.de>
@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Jun 15, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(CI): fix merge conflict resolution for nightly-testing [Merged by Bors] - chore(CI): fix merge conflict resolution for nightly-testing Jun 15, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 15, 2026
felixpernegger pushed a commit to felixpernegger/mathlib4 that referenced this pull request Jun 16, 2026
…ver-community#40257)

Resolving merge conflicts in favor of `nightly-testing` when merging `master` may be convenient for nightly maintainers, but it can lead to changes made on `master` accidentally being dropped again later in the bump PR. For an example case, see leanprover-community#40189 (see [#PR reviews > leanprover-community#39443 &leanprover-community#96;nonempty_preimage_iff&leanprover-community#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339443.20.60nonempty_preimage_iff.60/near/599885755) for an explanation of what happened).

Resolving conflicts in favor of `master` means that `nightly-testing` will rather break than silently undoing changes made on `master`.

Co-authored-by: Joscha <joscha@plugh.de>
gasparattila pushed a commit to gasparattila/mathlib4 that referenced this pull request Jun 16, 2026
…ver-community#40257)

Resolving merge conflicts in favor of `nightly-testing` when merging `master` may be convenient for nightly maintainers, but it can lead to changes made on `master` accidentally being dropped again later in the bump PR. For an example case, see leanprover-community#40189 (see [#PR reviews > leanprover-community#39443 &leanprover-community#96;nonempty_preimage_iff&leanprover-community#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339443.20.60nonempty_preimage_iff.60/near/599885755) for an explanation of what happened).

Resolving conflicts in favor of `master` means that `nightly-testing` will rather break than silently undoing changes made on `master`.

Co-authored-by: Joscha <joscha@plugh.de>
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Jun 18, 2026
…ver-community#40257)

Resolving merge conflicts in favor of `nightly-testing` when merging `master` may be convenient for nightly maintainers, but it can lead to changes made on `master` accidentally being dropped again later in the bump PR. For an example case, see leanprover-community#40189 (see [#PR reviews > leanprover-community#39443 &leanprover-community#96;nonempty_preimage_iff&leanprover-community#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339443.20.60nonempty_preimage_iff.60/near/599885755) for an explanation of what happened).

Resolving conflicts in favor of `master` means that `nightly-testing` will rather break than silently undoing changes made on `master`.

Co-authored-by: Joscha <joscha@plugh.de>
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…ver-community#40257)

Resolving merge conflicts in favor of `nightly-testing` when merging `master` may be convenient for nightly maintainers, but it can lead to changes made on `master` accidentally being dropped again later in the bump PR. For an example case, see leanprover-community#40189 (see [#PR reviews > leanprover-community#39443 &leanprover-community#96;nonempty_preimage_iff&leanprover-community#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339443.20.60nonempty_preimage_iff.60/near/599885755) for an explanation of what happened).

Resolving conflicts in favor of `master` means that `nightly-testing` will rather break than silently undoing changes made on `master`.

Co-authored-by: Joscha <joscha@plugh.de>
bryangingechen pushed a commit to jcommelin/mathlib4 that referenced this pull request Jun 22, 2026
…ver-community#40257)

Resolving merge conflicts in favor of `nightly-testing` when merging `master` may be convenient for nightly maintainers, but it can lead to changes made on `master` accidentally being dropped again later in the bump PR. For an example case, see leanprover-community#40189 (see [#PR reviews > leanprover-community#39443 &leanprover-community#96;nonempty_preimage_iff&leanprover-community#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339443.20.60nonempty_preimage_iff.60/near/599885755) for an explanation of what happened).

Resolving conflicts in favor of `master` means that `nightly-testing` will rather break than silently undoing changes made on `master`.

Co-authored-by: Joscha <joscha@plugh.de>
@Garmelon
Garmelon deleted the fix-nightly-conflict-resolution branch July 10, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants