-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: solve equalities of instances in convert
#40663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vierkantor
wants to merge
8
commits into
leanprover-community:master
Choose a base branch
from
Vierkantor:convert-preTransparency-instances
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−2
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e53e578
feat: solve equalities of instances in `convert`
Vierkantor 70b799f
Merge remote-tracking branch 'upstream/master' into convert-preTransp…
Vierkantor 9049d59
Fix
Vierkantor 652cd22
Merge remote-tracking branch 'upstream/master' into convert-preTransp…
Vierkantor b4d1c4f
`preTransparency` lowering is not needed (anymore)
Vierkantor 9f3cfb8
Use `guard_target` instead of `guard_msgs`
Vierkantor 9f56020
Merge remote-tracking branch 'upstream/master' into convert-preTransp…
Vierkantor e7263da
Fixes (remove extra steps since `convert` became more powerful)
Vierkantor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import Mathlib.RingTheory.UniqueFactorizationDomain.Nat | ||
| import Mathlib.Tactic.Convert | ||
|
|
||
| private axiom test_sorry : ∀ {α}, α | ||
|
|
||
| /-! `convert` should not pop up goals about instances. -/ | ||
| example {a b c : ℕ} (hab : instLTNat.lt a b) : Nat.instLinearOrder.toLT.lt a c := by | ||
| convert (preTransparency := .reducible) hab | ||
| · guard_target =ₛ Nat.instLinearOrder.toLT = instLTNat | ||
| exact test_sorry | ||
| · guard_target =ₛ c = b | ||
| exact test_sorry | ||
|
|
||
| #guard_msgs in | ||
| example {a b c : ℕ} (hab : instLTNat.lt a b) : Nat.instLinearOrder.toLT.lt a c := by | ||
| convert (preTransparency := .instances) hab | ||
| guard_target =ₛ c = b | ||
| exact test_sorry | ||
|
|
||
| example (q z : Nat) : semigroupDvd.dvd q z := by | ||
| convert_to (preTransparency := .reducible) q ^ 1 ∣ z | ||
| · guard_target =ₛ semigroupDvd = Nat.instDvd | ||
| exact test_sorry | ||
| · guard_target =ₛ q = q ^ 1 | ||
| exact test_sorry | ||
| · guard_target =ₛ q ^ 1 ∣ z | ||
| exact test_sorry | ||
|
|
||
| example (q z : Nat) : semigroupDvd.dvd q z := by | ||
| convert_to (preTransparency := .instances) q ^ 1 ∣ z | ||
| · guard_target =ₛ q = q ^ 1 | ||
| exact test_sorry | ||
| · guard_target =ₛ q ^ 1 ∣ z | ||
| exact test_sorry |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.