Skip to content

[Merged by Bors] - fix(Tactic/Convert): support over-applications again#40740

Closed
JovanGerb wants to merge 4 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-convert-overapplications
Closed

[Merged by Bors] - fix(Tactic/Convert): support over-applications again#40740
JovanGerb wants to merge 4 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-convert-overapplications

Conversation

@JovanGerb

@JovanGerb JovanGerb commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This PR fixes a regression introduced in #38071, which had caused the congruence algorithm of convert to not support over-applications.

I added a test to show this now works again.


Open in Gitpod

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

PR summary d63dfe5806

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit d63dfe5).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit d63dfe5806
Reference commit aea5d67c4f

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joneugster joneugster self-assigned this Jun 25, 2026
@joneugster

Copy link
Copy Markdown
Contributor

thanks!

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by joneugster.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 25, 2026
@ocfnash

ocfnash commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@JovanGerb The PR title and the comment that becomes the commit message seem to contradict each other. Can you please fix this before sending this to master.

Otherwise I trust this is the right move.

bors d+

@mathlib-bors mathlib-bors Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 30, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

✌️ JovanGerb can now approve this pull request until 2026-07-14 15:10 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

⚠️ This delegation only covers changes within Archive/**, Counterexamples/**, docs/**, DownstreamTest/**, Mathlib/**, MathlibTest/**, widget/**, Archive.lean, Counterexamples.lean, docs.lean, Mathlib.lean; an author commit touching anything else will revoke it. Bors also revokes it if a later push changes too many files for it to check the full list — even if it stays within scope.

@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 30, 2026
@JovanGerb

Copy link
Copy Markdown
Contributor Author

bors r+

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jun 30, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 30, 2026
This PR fixes a regression introduced in #38071, which had caused the congruence algorithm of `convert` to not support over-applications.

I added a test to show this now works again.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jun 30, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title fix(Tactic/Convert): support over-applications again [Merged by Bors] - fix(Tactic/Convert): support over-applications again Jun 30, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 30, 2026
@mathlib-bors mathlib-bors Bot removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 30, 2026
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 4, 2026
…unity#40740)

This PR fixes a regression introduced in leanprover-community#38071, which had caused the congruence algorithm of `convert` to not support over-applications.

I added a test to show this now works again.
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Jul 11, 2026
…unity#40740)

This PR fixes a regression introduced in leanprover-community#38071, which had caused the congruence algorithm of `convert` to not support over-applications.

I added a test to show this now works again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants