Skip to content

chore(RingTheory/Ideal/Norm/RelNorm): switch over to new definitions of ramificationIdx and inertiaDeg#41077

Open
tb65536 wants to merge 5 commits into
leanprover-community:masterfrom
tb65536:tb_ref04793
Open

chore(RingTheory/Ideal/Norm/RelNorm): switch over to new definitions of ramificationIdx and inertiaDeg#41077
tb65536 wants to merge 5 commits into
leanprover-community:masterfrom
tb65536:tb_ref04793

Conversation

@tb65536

@tb65536 tb65536 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This PR switches the file RingTheory/Ideal/Norm/RelNorm.lean over to the new definitions of ramificationIdx and inertiaDeg.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory labels Jun 26, 2026
@github-actions github-actions Bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

PR summary c71c87de96

Import changes exceeding 2%

% File
+11.88% Mathlib.RingTheory.DedekindDomain.Factorization

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.DedekindDomain.Factorization 2155 2411 +256 (+11.88%)
Mathlib.RingTheory.Ideal.Norm.RelNorm 2426 2425 -1 (-0.04%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.Ideal.Norm.RelNorm -1
Mathlib.AlgebraicGeometry.EllipticCurve.LFunction 114
5 files Mathlib.NumberTheory.Height.NumberField Mathlib.NumberTheory.NumberField.AdeleRing Mathlib.NumberTheory.NumberField.Completion.FinitePlace Mathlib.NumberTheory.NumberField.FinitePlaces Mathlib.NumberTheory.NumberField.ProductFormula
118
Mathlib.RingTheory.DedekindDomain.FiniteAdeleRing 141
Mathlib.Topology.Algebra.Ring.Compact 218
Mathlib.Algebra.Module.Torsion.PrimaryComponent Mathlib.RingTheory.DedekindDomain.Factorization 256

Declarations diff (regex)

+ IsDedekindDomain.ramificationIdx'_eq_factors_count
+ ramificationIdx_eq_ramificationIdx''

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit c71c87d).

  • +2 new declarations
  • −0 removed declarations
+Ideal.IsDedekindDomain.ramificationIdx'_eq_factors_count
+Ideal.ramificationIdx_eq_ramificationIdx''

No changes to strong technical debt.

No changes to weak technical debt.

Current commit c71c87de96
Reference commit 571b8a8e54

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant