Skip to content

feat(Logic/Function/Defs): add Function.diag#41082

Open
wrenna-robson wants to merge 2 commits into
leanprover-community:masterfrom
wrenna-robson:function_diag
Open

feat(Logic/Function/Defs): add Function.diag#41082
wrenna-robson wants to merge 2 commits into
leanprover-community:masterfrom
wrenna-robson:function_diag

Conversation

@wrenna-robson

Copy link
Copy Markdown
Collaborator

Adds a name and notation for the function fun x => (x, x).


Open in Gitpod

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

PR summary b7594a282f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ diag_apply
+ diag_comp
+ fst_comp_diag
+ injective_diag
+ map_comp_diag
+ prod_id_id
+ snd_comp_diag
+ swap_comp_diag
+-+ diag

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit b7594a282f
Reference commit 571b8a8e54

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@wrenna-robson wrenna-robson changed the title feat(Logic/Function/Defs): Add Function.diag feat(Logic/Function/Defs): add Function.diag Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant