-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(RingTheory): etale lifting property of henselian local rings #41086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erdOne
wants to merge
10
commits into
leanprover-community:master
Choose a base branch
from
erdOne:erd1/henselianStuff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
316d7d6
feat(RingTheory): etale lifting property of henselian local rings
erdOne a3b4e38
fix
erdOne 3b7d379
Apply suggestions from code review
erdOne 0598017
address comments
erdOne 5abc0fe
Merge branch 'erd1/henselianStuff' of https://github.com/erdOne/mathl…
erdOne 8ae282f
fix
erdOne b50adef
oops
erdOne f95fe6a
oops
erdOne d3b6170
fix
erdOne a010cae
Apply suggestion from @chrisflav
erdOne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /- | ||
| Copyright (c) 2026 Andrew Yang. All rights reserved. | ||
| Released under Apache 2.0 license as described in the file LICENSE. | ||
| Authors: Andrew Yang | ||
| -/ | ||
| module | ||
|
|
||
| public import Mathlib.RingTheory.Flat.Stability | ||
| public import Mathlib.RingTheory.Idempotents | ||
|
|
||
| /-! # Instances on corners -/ | ||
|
|
||
| @[expose] public section | ||
|
|
||
| variable {R A : Type*} [CommSemiring R] | ||
| [CommSemiring A] [Algebra R A] {e : A} (he : IsIdempotentElem e) | ||
|
|
||
| instance [Module.Projective R A] : Module.Projective R he.Corner := | ||
| .of_split ⟨⟨Subtype.val, fun _ _ ↦ rfl⟩, fun _ _ ↦ rfl⟩ | ||
| (IsScalarTower.toAlgHom _ A _).toLinearMap | ||
| (LinearMap.ext fun a ↦ Subtype.ext ((Subsemigroup.mem_corner_iff he).mp a.2).2) | ||
|
|
||
| instance [Module.Flat R A] : Module.Flat R he.Corner := | ||
| .trans R A _ | ||
|
|
||
| instance [Module.Finite R A] : Module.Finite R he.Corner := | ||
| .of_surjective (IsScalarTower.toAlgHom _ _ _).toLinearMap he.algebraMap_corner_surjective | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,7 @@ Authors: Andrew Yang | |||||
| -/ | ||||||
| module | ||||||
|
|
||||||
| public import Mathlib.Algebra.Algebra.Tower | ||||||
| public import Mathlib.Algebra.BigOperators.Fin | ||||||
| public import Mathlib.Algebra.Ring.GeomSum | ||||||
| public import Mathlib.RingTheory.Ideal.Quotient.Operations | ||||||
|
|
@@ -587,6 +588,47 @@ instance [NonUnitalCommRing R] (idem : IsIdempotentElem e) : CommRing idem.Corne | |||||
| __ : NonUnitalCommRing idem.Corner := | ||||||
| inferInstanceAs <| NonUnitalCommRing (NonUnitalRing.corner e) | ||||||
|
|
||||||
| instance {R S : Type*} [CommSemiring R] [Semiring S] [Algebra R S] | ||||||
| {e : S} (he : IsIdempotentElem e) : Algebra R he.Corner where | ||||||
| smul r x := ⟨r • x.1, by | ||||||
| simp [he, Subsemigroup.mem_corner_iff, (Subsemigroup.mem_corner_iff he).mp x.2]⟩ | ||||||
|
erdOne marked this conversation as resolved.
|
||||||
| algebraMap := | ||||||
| { toFun r := ⟨r • e, by simp [he, Subsemigroup.mem_corner_iff, he.eq]⟩ | ||||||
| map_one' := by simp; rfl | ||||||
| map_mul' a b := Subtype.ext <| show (a * b) • e = (a • e) * (b • e) by | ||||||
| simp [he.eq, ← mul_smul, mul_comm] | ||||||
| map_zero' := by simp; rfl | ||||||
| map_add' a b := Subtype.ext (add_smul _ _ _) } | ||||||
| commutes' r x := Subtype.ext (show r • e * x.1 = x.1 * r • e by | ||||||
| simp [(Subsemigroup.mem_corner_iff he).mp x.2]) | ||||||
| smul_def' r x := Subtype.ext (show r • x.1 = (r • e) * x.1 by | ||||||
| simp [(Subsemigroup.mem_corner_iff he).mp x.2]) | ||||||
|
|
||||||
| instance {R R' S : Type*} [CommSemiring R] [CommSemiring R'] [Semiring S] [Algebra R S] | ||||||
| [Algebra R R'] [Algebra R' S] [IsScalarTower R R' S] | ||||||
| {e : S} (he : IsIdempotentElem e) : IsScalarTower R R' he.Corner := | ||||||
| .of_algebraMap_eq fun _ ↦ Subtype.ext (IsScalarTower.algebraMap_smul _ _ _).symm | ||||||
|
|
||||||
| @[simp] | ||||||
| lemma IsIdempotentElem.algebraMap_corner_apply | ||||||
| {R S : Type*} [CommSemiring R] [Semiring S] [Algebra R S] | ||||||
| {e : S} (he : IsIdempotentElem e) (x : R) : | ||||||
| (algebraMap R he.Corner x).1 = x • e := rfl | ||||||
|
|
||||||
| lemma IsIdempotentElem.algebraMap_corner_surjective [CommSemiring R] | ||||||
| {e : R} (he : IsIdempotentElem e) : | ||||||
| Function.Surjective (algebraMap R he.Corner) := | ||||||
| fun x ↦ ⟨x.1, Subtype.ext ((Subsemigroup.mem_corner_iff he).mp x.2).2⟩ | ||||||
|
|
||||||
| lemma IsIdempotentElem.ker_algebraMap_corner [CommRing R] {e : R} (he : IsIdempotentElem e) : | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| RingHom.ker (algebraMap R he.Corner) = Ideal.span {1 - e} := by | ||||||
| apply le_antisymm | ||||||
| · intro x hx | ||||||
| refine Ideal.mem_span_singleton.mpr ⟨x, ?_⟩ | ||||||
| simp [show x * e = 0 from congr($(hx).1), sub_mul, mul_comm e] | ||||||
| · simpa [Ideal.span_le, sub_eq_zero, -FaithfulSMul.ker_algebraMap_eq_bot] using! | ||||||
| Subtype.ext he.eq.symm | ||||||
|
|
||||||
| variable {I : Type*} [Fintype I] {e : I → R} | ||||||
|
|
||||||
| /-- A complete orthogonal family of central idempotents in a semiring | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /- | ||
| Copyright (c) 2026 Andrew Yang. All rights reserved. | ||
| Released under Apache 2.0 license as described in the file LICENSE. | ||
| Authors: Andrew Yang | ||
| -/ | ||
| module | ||
| public import Mathlib.RingTheory.IntegralClosure.IsIntegralClosure.Basic | ||
| public import Mathlib.RingTheory.LocalRing.RingHom.Basic | ||
|
|
||
| /-! # Integral ring homomorphisms over local rings are local -/ | ||
|
|
||
| @[expose] public section | ||
|
|
||
| variable {R S : Type*} [CommRing R] [CommRing S] [Algebra R S] | ||
|
|
||
| instance [IsLocalRing R] [Algebra.IsIntegral R S] [Nontrivial S] : | ||
| IsLocalHom (algebraMap R S) := by | ||
| have : (algebraMap R S).kerLift.IsIntegral := | ||
| .tower_top (Ideal.Quotient.mk _) _ | ||
| (by have := algebraMap_isIntegral_iff.mpr ‹Algebra.IsIntegral R S›; exact this) | ||
| have := this.isLocalHom (algebraMap R S).kerLift_injective | ||
| have : Nontrivial (R ⧸ RingHom.ker (algebraMap R S)) := | ||
| Ideal.Quotient.nontrivial_iff.mpr (RingHom.ker_ne_top _) | ||
| have : IsLocalHom (Ideal.Quotient.mk (RingHom.ker (algebraMap R S))) := | ||
| .of_surjective _ Ideal.Quotient.mk_surjective | ||
| exact RingHom.isLocalHom_comp (algebraMap R S).kerLift (Ideal.Quotient.mk _) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you improve this docstring?