Skip to content

chore(AlgebraicGeometry): add LocallyRingedSpace.residue#41087

Open
chrisflav wants to merge 2 commits into
leanprover-community:masterfrom
chrisflav:lrs-residue-fix
Open

chore(AlgebraicGeometry): add LocallyRingedSpace.residue#41087
chrisflav wants to merge 2 commits into
leanprover-community:masterfrom
chrisflav:lrs-residue-fix

Conversation

@chrisflav

Copy link
Copy Markdown
Member

This aligns the API with the Scheme case.


Open in Gitpod

@chrisflav chrisflav added the t-algebraic-geometry Algebraic geometry label Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

PR summary 5ad14988f7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ instance (x : X) : Epi (X.residue x)
+ residue
+ residue_surjective

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 5ad1498).

  • +4 new declarations
  • −0 removed declarations
+AlgebraicGeometry.LocallyRingedSpace.instEpiCommRingCatResidue
+AlgebraicGeometry.LocallyRingedSpace.residue
+AlgebraicGeometry.LocallyRingedSpace.residue_comp_residueFieldMap_eq_stalkMap_comp_residue_assoc
+AlgebraicGeometry.LocallyRingedSpace.residue_surjective

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 5ad14988f7
Reference commit 571b8a8e54

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant