Skip to content

feat(MeasureTheory/MeasurableSpace/Basic): add map_comap_eq_of_surjective and measurable_comap_iff_right#41090

Open
teorth wants to merge 1 commit into
leanprover-community:masterfrom
teorth:comap
Open

feat(MeasureTheory/MeasurableSpace/Basic): add map_comap_eq_of_surjective and measurable_comap_iff_right#41090
teorth wants to merge 1 commit into
leanprover-community:masterfrom
teorth:comap

Conversation

@teorth

@teorth teorth commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

We have nine map_comap_eq_of_surjective lemmas for Submonoid, Subgroup, Subring, etc., but were lacking one for MeasurableSpace. This PR adds the analogous lemma; as an application it also establishes a dual version of measurable_comap_iff involving composition on the right rather than the left.


Note: I have no applications in mind for this PR, so it can be considered low priority.

Discussed on Zulip here.

Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 26, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@teorth teorth changed the title feat(MeasureTheory/MeasurableSpace/Basic) add map_comap_eq_of_siurjective and measurable feat(MeasureTheory/MeasurableSpace/Basic) add map_comap_eq_of_surjective and measurable_comap_iff_right Jun 26, 2026
@github-actions github-actions Bot added the t-measure-probability Measure theory / Probability theory label Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

PR summary 99ec11027c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ map_comap_eq_of_surjective
+ measurable_comap_iff_right

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 99ec110).

  • +2 new declarations
  • −0 removed declarations
+MeasurableSpace.map_comap_eq_of_surjective
+measurable_comap_iff_right

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 99ec11027c
Reference commit 005f0aa67b

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@teorth teorth changed the title feat(MeasureTheory/MeasurableSpace/Basic) add map_comap_eq_of_surjective and measurable_comap_iff_right feat(MeasureTheory/MeasurableSpace/Basic): add map_comap_eq_of_surjective and measurable_comap_iff_right Jun 26, 2026
Comment on lines +156 to +157
apply le_antisymm _ le_map_comap
intro S hS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to be using apply where one of the _ holes becomes a new goal, see #mathlib4 > linter requests @ 💬
While we're here, let's also merge in the next line intro S hS as well

Suggested change
apply le_antisymm _ le_map_comap
intro S hS
refine le_antisymm (fun S hS => ?_) le_map_comap

Comment on lines +211 to +213
simp only [measurable_iff_comap_le, ← comap_comp]
refine ⟨ comap_mono, fun h ↦ ?_ ⟩
simpa only [map_comap_eq_of_surjective hg] using map_mono (f := g) h

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
simp only [measurable_iff_comap_le, ← comap_comp]
refine ⟨ comap_mono, fun h ↦ ?_ ⟩
simpa only [map_comap_eq_of_surjective hg] using map_mono (f := g) h
rw [measurable_iff_le_map, measurable_iff_le_map, ← map_comp, map_comap_eq_of_surjective hg]

@plp127 plp127 added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants