feat(Analysis): strengthen bounds for sin#41094
Open
b-mehta wants to merge 3 commits into
Open
Conversation
PR summary 7b507bb714Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR strengthens various bounds for
Real.sinin mathlib.The statement
Complex.sin_boundnow has a quintic right hand side with a smaller constant. This bound is always better in the range where the theorem applies. The same is true forReal.sin_bound.Since these changes broke the proof of
sin_pos_of_pos_of_le_one, I fixed and golfed this proof.Next
sin_gt_sub_cubeis given a tight constant, and its range of validity is extended, and the proof is the same length. A version for weak inequality, and a version with absolute value is also added.